After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 642393 - [filesrc] Fails setting the same uri it's setting in the uri queries.
[filesrc] Fails setting the same uri it's setting in the uri queries.
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal normal
: 0.10.33
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-02-15 16:33 UTC by Andoni Morales
Modified: 2011-02-15 21:50 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
fix escaping of file uris (970 bytes, patch)
2011-02-15 21:09 UTC, Andoni Morales
committed Details | Review

Description Andoni Morales 2011-02-15 16:33:44 UTC
filesrc fills uri queries with an escaped uri, that it's enable to reuse itself:


0:00:00.137679063 10568  0x8d26cf8 DEBUG                 hlssrc gsthlssrc.c:326:gst_hls_src_sink_event:<hlssrc0> Got EOS on the sink pad: main playlist fetched
0:00:00.137700326 10568  0x8d26cf8 INFO                  hlssrc gsthlssrc.c:613:gst_hls_src_set_location:<hlssrc0> Changed location: file://%2Ftmp%2Ftest.m3u8
0:00:00.137949389 10568  0x8d325f8 INFO                  hlssrc gsthlssrc.c:800:gst_hls_src_update_playlist:<hlssrc0> Updating the playlist file://%2Ftmp%2Ftest.m3u8
0:00:00.137962719 10568  0x8d325f8 DEBUG                 hlssrc gsthlssrc.c:560:gst_hls_src_make_fetcher:<hlssrc0> Creating fetcher for the URI:file://%2Ftmp%2Ftest.m3u8
0:00:00.138100771 10568  0x8d325f8 INFO     GST_ELEMENT_FACTORY gstelementfactory.c:371:gst_element_factory_create: creating element "filesrc"
0:00:00.138150061 10568  0x8d325f8 INFO        GST_ELEMENT_PADS gstelement.c:722:gst_element_add_pad:<GstBaseSrc@0x8cf08f8> adding pad 'src'
0:00:00.138186639 10568  0x8d325f8 WARN                 filesrc gstfilesrc.c:1133:gst_file_src_uri_set_uri:<filesrc0> Invalid URI 'file://%2Ftmp%2Ftest.m3u8' for filesrc: La URI·«file://%2Ftmp%2Ftest.m3u8»·es inválida
Comment 1 Sebastian Dröge (slomo) 2011-02-15 16:48:12 UTC
commit 140dca43f35d5438d8c5300bd150e9fb69beea59
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Tue Feb 15 17:46:22 2011 +0100

    playbin2: Optimize autoplug-continue handler a bit
    
    Don't build merge the caps of all sinks but check them one-by-one
    until one supports the caps. Also get reffed caps from the sinkpads
    instead of a writable copy and add debug output if a sink claims to
    support ANY caps.

commit 555e33800867d68bfed0e27546448e738acabf35
Author: Akihiro Tsukada <tskd2@yahoo.co.jp>
Date:   Tue Feb 15 17:24:28 2011 +0100

    playbin2: Fix handling of non-raw custom sinks
    
    When autoplugging elements in decodebin2, check if
    the caps are supported by one of the sink before
    continuing autoplugging.
    
    Fixes bug #642174.
Comment 2 Sebastian Dröge (slomo) 2011-02-15 16:48:40 UTC
Hrm, wrong bug...
Comment 3 Andoni Morales 2011-02-15 21:09:12 UTC
Created attachment 180945 [details] [review]
fix escaping of file uris

This should escape and make a uri properly for filenames.
Comment 4 Sebastian Dröge (slomo) 2011-02-15 21:50:34 UTC
commit 43cb8684e5de620b8a2b1c7b40b0da2204d512a8
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Tue Feb 15 22:49:26 2011 +0100

    file{src,sink}: Fix unit tests
    
    filesink and filesrc should return exactly the same URI as passed
    and must not escape path separators.

commit 840769032fece9180dc0cbb4ca94a87a5a9a550f
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Tue Feb 15 22:48:44 2011 +0100

    filesink: Fix escaping of URIs
    
    Especially don't escape / as path separators

commit 5af29e9d747e0a403afa4b556b9beae9aadb7969
Author: Andoni Morales Alastruey <ylatuya@gmail.com>
Date:   Tue Feb 15 22:05:31 2011 +0100

    filesrc: Fix escaping of file uris
    
    Fixes bug #642393.