After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 642232 - theoraenc sets Video quality to zero when explicitely setting the bitrate to 0
theoraenc sets Video quality to zero when explicitely setting the bitrate to 0
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: 0.10.33
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-02-13 14:49 UTC by Sjoerd Simons
Modified: 2011-02-14 15:05 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
proposed patch (1.66 KB, patch)
2011-02-13 14:49 UTC, Sjoerd Simons
none Details | Review

Description Sjoerd Simons 2011-02-13 14:49:05 UTC
Created attachment 180773 [details] [review]
proposed patch

See subject. If a user explicitely sets the dfault value for the bitrate property the video quality setting will change to 0 while encoding in vbr mode... :(
Comment 1 Wim Taymans 2011-02-14 15:05:04 UTC
commit 46f3e7c6fd9148677e97e01c5a29f07f59a132b3
Author: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Date:   Sun Feb 13 14:42:14 2011 +0000

    theoraenc: Don't reset the video quality setting the bitrate
    
    libtheora has two encoding modes, CBR, where it tries to hit a target
    bitrate and VBR where it tries to achieve a target quality.
    
    Internally if the target bitrate is set to anything other then 0 the
    encoding-mode is CBR.
    
    This means that the gstreamer element can leave the video_quality
    setting alone as long as the user is tweaking the bitrate. Which has the
    nice side-effect that if the user explicitely sets the bitrate to 0
    (which is actually the default), the quality value doesn't get reset and
    one ends up encoding VBR at quality-level 0...