GNOME Bugzilla – Bug 642232
theoraenc sets Video quality to zero when explicitely setting the bitrate to 0
Last modified: 2011-02-14 15:05:04 UTC
Created attachment 180773 [details] [review] proposed patch See subject. If a user explicitely sets the dfault value for the bitrate property the video quality setting will change to 0 while encoding in vbr mode... :(
commit 46f3e7c6fd9148677e97e01c5a29f07f59a132b3 Author: Sjoerd Simons <sjoerd.simons@collabora.co.uk> Date: Sun Feb 13 14:42:14 2011 +0000 theoraenc: Don't reset the video quality setting the bitrate libtheora has two encoding modes, CBR, where it tries to hit a target bitrate and VBR where it tries to achieve a target quality. Internally if the target bitrate is set to anything other then 0 the encoding-mode is CBR. This means that the gstreamer element can leave the video_quality setting alone as long as the user is tweaking the bitrate. Which has the nice side-effect that if the user explicitely sets the bitrate to 0 (which is actually the default), the quality value doesn't get reset and one ends up encoding VBR at quality-level 0...