GNOME Bugzilla – Bug 642071
Incorrect comparing of number of source and sink links when parsing a launch string
Last modified: 2011-02-14 14:10:29 UTC
Hi, The following line of code seems very suspect {{{ if (g_slist_length (link->src_pads) != g_slist_length (link->src_pads)) { }}} It is in gst/parse/grammar.py, in gst_parse_perform_link in the gstreamer tarball. For 0.10.32 it is at line 585. Found this while looking for something else, so I'm not 100% sure it leads to a problem, but thought I would submit it before it causes somebody else grief.
Original commit message :/ commit 3a897e2f301dc5ca800bc5b2d7efc74d2cc1c4a3 Author: Benjamin Otte <otte@gnome.org> Date: Tue Apr 8 21:59:44 2003 +0000 rewritten pipeline parsing lands. Have fun breaking it. Original commit message from CVS: rewritten pipeline parsing lands. Have fun breaking it. regressions: - No support for filtered links. If anybody needs this, please contact me and I'll add it as fast as possible. improvements: - The pipeline building actually works as expected. - syntax compatible nearly everywhere but more flexible - better property parsing (you can now set enums by name or nick) - uses locked_state to allow for delayed pads - can connect video pipelines without the need for queues - allows properties on bins - does not return a bin, but an element. You may want to read docs/random/company/gstparse to learn how it works. commit 8f9f95cd78ca2051c195591407f36caa633ffc51 Author: Stefan Kost <ensonic@users.sf.net> Date: Mon Feb 14 15:37:23 2011 +0200 parse-launch: fix typo in pad-list length comparision It was comparing the length with itself. Fixes #642071.