GNOME Bugzilla – Bug 640727
Links having a colon in the middle are not selected completely
Last modified: 2012-07-21 15:04:24 UTC
Created attachment 179437 [details] [review] proposed patch Originally reported as https://bugzilla.redhat.com/show_bug.cgi?id=655132 Basically having an URL that contains colon (":") in the middle of the link would make gnome-terminal select/underline only the first part of the string up to the colon. Such links are quite common nowadays. https://fedoraproject.org/wiki/Packaging:RPM_Source_Dir http://foo.bar/path/with/a/colon:foo The attached patch modifies regexps so that whole URL is selected properly.
Christian, have you tested the patch under various situations? I made it somewhat blindly, no idea if it breaks anything else. Just being precautious...
Not tested, no; just looks correct. A test suite for the URL regexes would be good to have :)
*** Bug 643060 has been marked as a duplicate of this bug. ***
Thanks for the bug report. This particular bug has already been reported into our bug tracking system, but please feel free to report any further bugs you find. *** This bug has been marked as a duplicate of bug 582899 ***
Please commit the patch.
commit 1eb9a8283fec7d1cc7492deb53d6705b52538b5c Author: Tomas Bzatek <tbzatek@redhat.com> Date: Tue Aug 2 15:06:14 2011 +0200 Don't split URL having a colon (":") in the middle Properly handle links like http://foo.bar/path/with/a/colon:foo This patch also avoids selecting trailing colon. https://bugzilla.gnome.org/show_bug.cgi?id=640727
*** Bug 582899 has been marked as a duplicate of this bug. ***