After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 640709 - [typefindfunctions] h264 typefinder registered with MPEG_VIDEO_CAPS
[typefindfunctions] h264 typefinder registered with MPEG_VIDEO_CAPS
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal minor
: 0.10.33
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-01-27 11:29 UTC by Philippe Normand
Modified: 2011-01-27 13:10 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
[typefindfunctions] register H264 typefinder with H264 caps (1.09 KB, patch)
2011-01-27 11:32 UTC, Philippe Normand
committed Details | Review

Description Philippe Normand 2011-01-27 11:29:33 UTC
Instead of H264_VIDEO_CAPS. line 4231 of gst/typefind/gsttypefindfunctions.c
Trivial patch incoming
Comment 1 Philippe Normand 2011-01-27 11:32:10 UTC
Created attachment 179421 [details] [review]
[typefindfunctions] register H264 typefinder with H264 caps
Comment 2 Tim-Philipp Müller 2011-01-27 12:22:25 UTC
How in the world did you discover that? :)

(Note that many typefinders don't register the caps they typefind...)

commit 749f541cc48b05c176f4d6eb78aba846c2f299ac
Author: Philippe Normand <pnormand@igalia.com>
Date:   Thu Jan 27 12:32:35 2011 +0100

    typefinding: register H264 typefinder with H264 caps
    
    https://bugzilla.gnome.org/show_bug.cgi?id=640709
Comment 3 Philippe Normand 2011-01-27 13:10:34 UTC
(In reply to comment #2)
> How in the world did you discover that? :)
> 

I was refactoring some code in WebKit that iterates over the typefind factories and builds a "mime-type cache" depending on the caps. Then I noticed video/x-h264 wasn't in the list.

> (Note that many typefinders don't register the caps they typefind...)
> 

Would it make sense to harmonize this?