After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 639730 - discoverer: Validate timeouts before processing them
discoverer: Validate timeouts before processing them
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
unspecified
Other All
: Normal normal
: 0.10.32
Assigned To: GStreamer Maintainers
GStreamer Maintainers
: 639729 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2011-01-17 10:15 UTC by Arun Raghavan
Modified: 2011-01-17 23:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
discoverer: Validate timeouts before processing them (1.52 KB, patch)
2011-01-17 10:15 UTC, Arun Raghavan 		committed Details | Review

Description Arun Raghavan 2011-01-17 10:15:21 UTC 
This patch is required to ensure that timeouts we receive during async discovery are valid.
Comment 1 Arun Raghavan 2011-01-17 10:15:24 UTC 
Created attachment 178480 [details] [review]
discoverer: Validate timeouts before processing them

This avoids a race where the timeout callback is scheduled to run but we
get sufficient information to finish discovery before actually getting
around to executing the callback. See the documentation of
g_source_is_destroyed() for more details.
Comment 2 Edward Hervey 2011-01-17 10:49:30 UTC 
*** Bug 639729 has been marked as a duplicate of this bug. ***
Comment 3 Tim-Philipp Müller 2011-01-17 23:52:14 UTC 
commit 65a298fdeee5b9214f83878a6d757e90d45562cb
Author: Arun Raghavan <arun.raghavan@collabora.co.uk>
Date:   Mon Jan 17 15:30:08 2011 +0530

    discoverer: Validate timeouts before processing them
    
    This avoids a race where the timeout callback is scheduled to run but we
    get sufficient information to finish discovery before actually getting
    around to executing the callback. See the documentation of
    g_source_is_destroyed() for more details.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=639730