After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 637590 - [PATCH] fix gst-plugins-bad compile against latest gtk+
[PATCH] fix gst-plugins-bad compile against latest gtk+
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
0.10.20
Other Linux
: Normal major
: 0.10.21
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-12-19 17:36 UTC by Saleem Abdulrasool
Modified: 2010-12-20 19:36 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gst-plugins-bad-compile-fix-for-gst-camera.patch (1.57 KB, patch)
2010-12-19 17:36 UTC, Saleem Abdulrasool 		needs-work Details | Review
0001-camerabin-fix-for-latest-GTK-API-changes.patch (1.99 KB, patch)
2010-12-20 15:20 UTC, Saleem Abdulrasool 		committed Details | Review

Description Saleem Abdulrasool 2010-12-19 17:36:55 UTC 
Created attachment 176713 [details] [review]
gst-plugins-bad-compile-fix-for-gst-camera.patch

The latest gtk+ dropped some more APIs, and that results in gst-plugins-bad not building against it.  The attached patch stops using those APIs.
Comment 1 Stefan Sauer (gstreamer, gtkdoc dev) 2010-12-20 08:53:04 UTC 
Could you please turn it into a git formatted patch applied against the latest version (git head). The changes look good, but the patch does not apply:
> patch --dry-run -p1 <gst-plugins-bad-0.10.20-api-fix-for-gst-camera.patch
patching file tests/examples/camerabin/gst-camera.c
Hunk #1 FAILED at 276.
Hunk #2 succeeded at 1157 (offset 1 line).
Hunk #3 succeeded at 1171 (offset 1 line).
Comment 2 Saleem Abdulrasool 2010-12-20 15:20:39 UTC 
Created attachment 176766 [details] [review]
0001-camerabin-fix-for-latest-GTK-API-changes.patch

Sorry about that, I thought Id git format-patch'ed it.

Thanks.
Comment 3 Stefan Sauer (gstreamer, gtkdoc dev) 2010-12-20 19:35:54 UTC 
There was a type in GTK_CHECK_VERSION macros. Committed the fixed version.
Comment 4 Stefan Sauer (gstreamer, gtkdoc dev) 2010-12-20 19:36:23 UTC 
Comment on attachment 176766 [details] [review]
0001-camerabin-fix-for-latest-GTK-API-changes.patch

with small correction