After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 637304 - Name Contains Entry is not exposing accessibility
Name Contains Entry is not exposing accessibility
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkComboBox
unspecified
Other Linux
: Normal normal
: 3.0
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2010-12-15 13:50 UTC by Pedro Villavicencio
Modified: 2011-03-16 20:49 UTC
See Also:
GNOME target: ---
GNOME version: 2.31/2.32

Attachments
Patch. (1.57 KB, patch)
2011-03-14 20:40 UTC, Mike Gorse 		committed Details | Review

Description Pedro Villavicencio 2010-12-15 13:50:45 UTC 
Hello,

We've been developing some automated tests and discovered that with gnome-utils 2.32 the accessibility on gnome-search-tool "Name Contains" text entry is not exposed, this was working fine on 2.30 and 2.31. This can be checked with Accerciser, you'll notice that there's no "Name Contains" text entry anymore on the child list of the combo.

Thanks,
Comment 1 Nagappan Alagappan 2011-03-14 18:38:42 UTC 
I could reproduce this issue with gedit as well:

To reproduce:
* Enable accessibility (either at-spi1 / at-spi2)
* Logout / Login (if enabling accessibility for the first time)
* Launch gedit
* Open Find / Replace dialog
* Launch accerciser
* Navigate to Combo box widget of Find / Replace dialog inside accerciser

Actual result:
Text widget not visible, so no way to enter data in combo box using accerciser

NOTE: This worked fine with all versions of Ubuntu 6.x to 10.x and started failing in Ubuntu 11.04

If you need further info, please let me know.

Thanks
Comment 2 Nagappan Alagappan 2011-03-14 18:44:52 UTC 
GTK version worked: 2.22.0 (Ubuntu 10.10)
GTK version where the above issue noticed: 2.24.0 (Ubuntu 11.04)
Comment 3 Mike Gorse 2011-03-14 20:40:49 UTC 
Created attachment 183383 [details] [review]
Patch.

This is a regression introduced in commit 883835 -- GAIL now looks at the
has-entry property of a combo box to determine whether it has a text child,
as is appropriate for new combo boxes, but the old GtkComboBoxEntry class does
not use this property.

This patch fixes it for the gtk-2-24 branch (it is a non-issue for GTK 3
since the class is deprecated).
Comment 4 Matthias Clasen 2011-03-16 17:25:35 UTC 
Review of attachment 183383 [details] [review]:

Looks good.
Comment 5 Mike Gorse 2011-03-16 20:49:21 UTC 
Should be fixed for gtk+ 2.24.4 (commit ddd632).