After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 636824 - Orca is at the mercy of speech-dispatcher's default priority
Orca is at the mercy of speech-dispatcher's default priority
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: speech
2.91.x
Other Linux
: Normal normal
: 2.91.4
Assigned To: Orca Maintainers
Orca Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-12-08 22:51 UTC by Michael Whapples
Modified: 2010-12-10 01:49 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch to make orca explicitly set speech-dispatcher's priority to message. (568 bytes, patch)
2010-12-08 22:51 UTC, Michael Whapples
committed Details | Review

Description Michael Whapples 2010-12-08 22:51:43 UTC
Created attachment 176107 [details] [review]
Patch to make orca explicitly set speech-dispatcher's priority to message.

If a user uses orca with speech-dispatcher for speech output then the way speech interrupts current speech could be affected if the default priority of speech-dispatcher were changed.

As an example output with priority message or important will not be interrupted by output of the same level but the later output will be queued to be output after the current message. If the priority level was text then other messages of level text will interrupt the current speech. Also note that messages of a higher priority will interrupt messages of a lower level (eg. message can interrupt text, important will interrupt text and message).

As orca uses the default level, then if the user were to change this it could affect orca's output. Also if the developers of speech-dispatcher were to change the default level this may impact on orca (eg. looking at the speechd.conf file and from what I have heard on the speechd list the default level might be meant to be text although currently it is a higher level, I don't know if what I have heard is wrong).

The solution seems to be to get orca to explicitly set the priority level it relies on. I have a patch for this to set it to use priority message which seems to be the correct level from what I understand.
Comment 1 Tomas Cerha 2010-12-09 00:45:15 UTC
Yes, that's it.  I fully support this patch.  I probably forgot to add 'set_priority()' when migrating form the deprecated 'speechd.Client' API to 'speechd.SSIPClient'.
Comment 2 Joanmarie Diggs (IRC: joanie) 2010-12-10 01:48:31 UTC
Comment on attachment 176107 [details] [review]
Patch to make orca explicitly set speech-dispatcher's priority to message.

http://git.gnome.org/browse/orca/commit/?id=0a75a1f03cd65afaa5823bb74d4e9519f8f13e4d
Comment 3 Joanmarie Diggs (IRC: joanie) 2010-12-10 01:49:37 UTC
Thanks Michael for the investigation and patch!

Thanks Tomas for the review!

:-)