GNOME Bugzilla – Bug 63648
gnome-games doesn't compile
Last modified: 2004-12-22 21:47:04 UTC
Package: gnome-games Severity: blocker Version: 1.4.0.3 Synopsis: gnome-games doesn't compile Bugzilla-Product: gnome-games Bugzilla-Component: general Description: Two things wrong: 1) Doesn't compile against gdk-pixbuf 0.13.0. 2) Doesn't compile against guile-1.5.4 gdk-pixbuf 0.12.0 (or thereabouts) changed it's location. It has handily provided a --cflags option to used, but gnome-games didn't bother using it (other needed libraries should probably be reviewed for this problem as well). patch -p1 << \EOF diff -ru gnome-games-1.4.0.3.orig/aisleriot/cscmi.c gnome-games-1.4.0.3/aisleriot/cscmi.c --- gnome-games-1.4.0.3.orig/aisleriot/cscmi.c Wed Jul 11 12:44:26 2001 +++ gnome-games-1.4.0.3/aisleriot/cscmi.c Fri Nov 2 12:50:18 2001 @@ -155,7 +155,7 @@ return SCM_EOL; } -SCM scm_add_slot(SCM slot) +SCM gg_scm_add_slot(SCM slot) { add_slot(slot); return SCM_EOL; @@ -278,7 +278,7 @@ gh_new_procedure1_0("set-statusbar-message", scm_set_statusbar_message); gh_new_procedure1_0("set-surface-layout", scm_set_surface_layout); gh_new_procedure0_0("reset-surface", scm_reset_surface); - gh_new_procedure1_0("add-slot", scm_add_slot); + gh_new_procedure1_0("add-slot", gg_scm_add_slot); gh_new_procedure1_0("get-slot", scm_get_slot); gh_new_procedure2_0("set-cards-c!", scm_set_cards); gh_new_procedure2_0("set-slot-y-expansion!", scm_set_slot_y_expansion); diff -ru gnome-games-1.4.0.3.orig/configure gnome-games-1.4.0.3/configure --- gnome-games-1.4.0.3.orig/configure Wed Jul 11 13:02:11 2001 +++ gnome-games-1.4.0.3/configure Fri Nov 2 12:35:39 2001 @@ -1270,7 +1270,7 @@ GTKXMHTML_LIBS="`$GNOME_CONFIG --libs-only-l gtkxmhtml`" ZVT_LIBS="`$GNOME_CONFIG --libs-only-l zvt`" GNOME_LIBDIR="`$GNOME_CONFIG --libs-only-L gnorba gnomeui`" - GNOME_INCLUDEDIR="`$GNOME_CONFIG --cflags gnorba gnomeui`" + GNOME_INCLUDEDIR="`$GNOME_CONFIG --cflags gnorba gnomeui gdk_pixbuf`" else echo "$ac_t""no" 1>&6 EOF The latest development version of guile provides a function called scm_add_slot() which clashes with aisleriot/cscmi.c. The following patch fixes the problem on *my* system. But it may not be sufficient to cover all cases. ------- Bug moved to this database by unknown@bugzilla.gnome.org 2001-11-02 18:52 ------- The original reporter (dalgoda@ix.netcom.com) of this bug does not have an account here. Reassigning to the exporter, unknown@bugzilla.gnome.org. Reassigning to the default owner of the component, gnome-games-maint@bugzilla.gnome.org.
The patch that came with this bug initially included changes to the 'configure' file, which is an autogenerated file. I've mucked around a bit, and created a patch to configure.in (which is the file from which 'configure' is generated) which I believe fixes the gdk_pixbuf CFLAGS error. The other half of the patch applied cleanly, so I've attached it as a second patch file.
Created attachment 5975 [details] [review] Add GDK-PIXBUF CFLAGS
Created attachment 5976 [details] [review] rename scm_add_slot to gg_scm_add_slot so that it doesn't conflict with guile 1.5
I just applied these patches to CVS.