GNOME Bugzilla – Bug 635375
Port to GSettings
Last modified: 2012-03-15 22:58:34 UTC
http://live.gnome.org/GnomeGoals/GSettingsMigration $ git grep gconf-c gui/simple-chooser/chooser-main.c:#include <gconf/gconf-client.h> gui/simple-chooser/gdm-host-chooser.c:#include <gconf/gconf-client.h> gui/simple-greeter/gdm-greeter-login-window.c:#include <gconf/gconf-client.h> gui/simple-greeter/gdm-greeter-panel.c:#include <gconf/gconf-client.h> gui/simple-greeter/gdm-greeter-session.c:#include <gconf/gconf-client.h> gui/simple-greeter/gdm-layouts.c:#include <gconf/gconf-client.h> gui/simple-greeter/gdm-recent-option-widget.c:#include <gconf/gconf-client.h> gui/simple-greeter/gdm-user-chooser-widget.c:#include <gconf/gconf-client.h> gui/simple-greeter/greeter-main.c:#include <gconf/gconf-client.h> gui/user-switch-applet/applet.c:#include <gconf/gconf-client.h>
I'm working on this. Can anyone convert the schemas from http://git.gnome.org/browse/gdm/tree/data/gdm.schemas.in.in using gsettings-schema-convert for me? I tried many times and gsettings-schema-convert doesn't work for me.
For the records... Traceback (most recent call last):
+ Trace 226450
res = main(sys.argv)
schema_root = parser.parse()
gconf_schema = GConfSchema(schema_node)
self.type = node.find('type').text
Same errors for me. Gonna convert it manually.
Created attachment 194869 [details] [review] Gschema xml file This is only the gschema migrated file.
the oversight here is that what you are looking at is not a gconf schema...
Created attachment 207183 [details] [review] use gsettings instead of gconf for simple greeter Hi, I've prepared a patch which converts usage of GConf in simple greeter to GSettings. There are no other GConf schemas in GDM other than the one for simple greeter. But simple greeter still uses GConf for getting some values. I've renamed keys to be in lowercase format and to use '-' for separation of words. Regards Marek
Hey thanks for looking into this. I'd like it if the greeter used the org.gnome.login-screen.gschema.xml schema that is already there (where it makes sense). The settings daemon / a11y bits etc aren't needed. We do lock down of session specific keys in a different way now, so they can just be dropped rather than migrated. Also you can drop wm-uses-compiz . that feature makes little sense and we should get rid of it.
Created attachment 207621 [details] [review] migration of GDM's simple-greeter from GConf to GSettings (In reply to comment #7) > Hey thanks for looking into this. > > I'd like it if the greeter used the org.gnome.login-screen.gschema.xml schema > that is already there (where it makes sense). > > The settings daemon / a11y bits etc aren't needed. We do lock down of session > specific keys in a different way now, so they can just be dropped rather than > migrated. > > Also you can drop wm-uses-compiz . that feature makes little sense and we > should get rid of it. Hi Ray, thank you for your answer. I've merged those keys into the org.gnome.login-screen.gschema.xml schema. But I haven't created a new child schema for them. If you want, I can do such a child schema (it should be quick). I've removed those settings-daemon and a11y schemas and the wm-use-compiz key. I've changed <summary> and <description> to <_summary> and <_description> for the merged keys. If it is not appropriate, I'll change it back. Also, there were one key which is the same in both schemas. It is disable-user-list. Simple greeter uses the one from the original schema now. There were also 2 similar keys, logo (login-screen) and logo-icon-name (simple-greeter) but the first one is more like logo-path, so I've merged the one from simple-greeter schema to login-screen schema too. Regards Marek
Hi Ray, do you think that the patch could go to 3.4 still? Marek
halfline: Can Marek's patch get a review, please?
it's on my radar
Thanks, i've commited this with minor changes.