After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 635291 - x264enc: "vbv-buf-capacity" property should have minimum value of 0
x264enc: "vbv-buf-capacity" property should have minimum value of 0
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-ugly
git master
Other Linux
: Normal normal
: 0.10.17
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-11-19 18:07 UTC by Tristan Matthews
Modified: 2010-12-29 18:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch to lower the minimum (1021 bytes, patch)
2010-11-19 18:07 UTC, Tristan Matthews 		committed Details | Review

Description Tristan Matthews 2010-11-19 18:07:12 UTC 
Created attachment 174869 [details] [review]
patch to lower the minimum

Since x264 clips its value internally, it would be nice if users could specify a lower minimum for vbv-buf-capacity than 300 ms.
Comment 1 Robert Swain 2010-12-29 16:28:14 UTC 
Looks OK and valid to me.
Comment 2 Tim-Philipp Müller 2010-12-29 18:33:30 UTC 
commit 71567bb0f92364964a6b223b949f3c0c869b4784
Author: Tristan Matthews <tristan@sat.qc.ca>
Date:   Fri Nov 19 13:01:35 2010 -0500

    x264: vbv-buf-capacity should have a minimum of 0
    
    x264 will clip this value internally, and users should be allowed to
    specify a lower value than 300 ms.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=635291
Comment 3 Tim-Philipp Müller 2010-12-29 18:33:54 UTC 
Comment on attachment 174869 [details] [review]
patch to lower the minimum

Pushed, thanks for the patch!