After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 635040 - Edit -> Stroke Path performs no action on an incomplete path
Edit -> Stroke Path performs no action on an incomplete path
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: General
2.6.11
Other All
: Normal normal
: 2.8
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2010-11-17 02:34 UTC by Ari Pollak
Modified: 2010-11-25 10:37 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Ari Pollak 2010-11-17 02:34:04 UTC
From http://bugs.debian.org/603309:


In a new buffer, select the path tool, then hold down the left mouse button when
moving the pointer from point A to B. After releasing we see a dashed
line on the screen, and we also notice the "Stroke path" menu item and
toolbox button has now become clickable. However clicking it is of no use,
as one needs to do more mouse work, to make a solid line appear, not just
dashed lines. Only upon appearance of a solid line should the "Stroke
path" button and menu item become clickable.

The Stroke Path menu should probably just be disabled in the case of only a single point in the path existing, since I can't think of a case where it would actually produce anything. Or it could produce the same error message as stroking with the paint tool.
Comment 1 Michael Natterer 2010-11-25 10:17:31 UTC
Well there *is* a path present, it's just not strokable. That
would be confusing to the user. We should rather show an error
message for this rare corner case imho.
Comment 2 Michael Natterer 2010-11-25 10:37:08 UTC
Fixed in master. Too harmless to fix in 2.6.

commit d46b53f63ddfe3fd1189f599842af683c2e8b0b0
Author: Michael Natterer <mitch@gimp.org>
Date:   Thu Nov 25 11:31:40 2010 +0100

    Bug 635040 - Edit -> Stroke Path performs no action on an incomplete path
    
    Add error reporting to gimp_drawable_stroke_vectors() and produce the
    same warning as the paint core when trying to stroke a path with zero
    or one points only.

 app/core/gimpdrawable-stroke.c |   76 +++++++++++++++++++++++++---------------
 app/core/gimpdrawable-stroke.h |   46 ++++++++++++-----------
 app/tools/gimprectangletool.c  |    4 +-
 app/vectors/gimpvectors.c      |   17 +++++----
 4 files changed, 84 insertions(+), 59 deletions(-)

(the change to GimpRectangleTool was pushed accidentially, but it entirely
harmless)