After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 633918 - [fakesink] [PATCH] print sink-message events like a message and its structure
[fakesink] [PATCH] print sink-message events like a message and its structure
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal normal
: 0.10.32
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-11-03 16:05 UTC by Andoni Morales
Modified: 2010-12-03 08:29 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
print sink-message events like a message and it's structure (1.81 KB, patch)
2010-11-03 16:05 UTC, Andoni Morales
needs-work Details | Review
0001-fakesink-Print-sink-message-events-like-a-message-an.patch (1.70 KB, patch)
2010-11-09 09:44 UTC, Andoni Morales
none Details | Review
0001-fakesink-Print-sink-message-events-like-a-message-an.patch (1.70 KB, patch)
2010-11-09 09:46 UTC, Andoni Morales
accepted-commit_after_freeze Details | Review

Description Andoni Morales 2010-11-03 16:05:26 UTC
Created attachment 173786 [details] [review]
print sink-message events like a  message and it's structure 

sink-message events are supposed to be treated like messages by sinks. In this case print them like a message and the message's structure
Comment 1 Stefan Sauer (gstreamer, gtkdoc dev) 2010-11-08 13:19:13 UTC
Review of attachment 173786 [details] [review]:

Good idea. I can push after the small detail got fixed and git is open for commits.

::: plugins/elements/gstfakesink.c
@@ +414,2 @@
+    if (!g_strcmp0 ("sink-message", str_name)) {
+      GstMessage *msg;

wouldn't it be better to do GST_EVENT_TYPE(event)==GST_EVENT_SINK_MESSAGE?
Comment 2 Andoni Morales 2010-11-08 14:10:40 UTC
Review of attachment 173786 [details] [review]:

Of course :)
Comment 3 Andoni Morales 2010-11-09 09:44:55 UTC
Created attachment 174121 [details] [review]
0001-fakesink-Print-sink-message-events-like-a-message-an.patch

Make use of "GST_EVENT_TYPE (event) == GST_EVENT_SINK_MESSAGE" as suggested in previous comment
Comment 4 Andoni Morales 2010-11-09 09:46:36 UTC
Created attachment 174122 [details] [review]
0001-fakesink-Print-sink-message-events-like-a-message-an.patch

I attached the wrong file in the previous commit
Comment 5 Stefan Sauer (gstreamer, gtkdoc dev) 2010-11-09 15:14:11 UTC
Comment on attachment 174122 [details] [review]
0001-fakesink-Print-sink-message-events-like-a-message-an.patch

Looks good now. I'll push this after freeze.