After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 633555 - discoverer: use specific types in getters, rename some boolean getters
discoverer: use specific types in getters, rename some boolean getters
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-python
git master
Other Linux
: Normal blocker
: 0.10.20
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-10-30 15:28 UTC by Tim-Philipp Müller
Modified: 2010-11-01 11:06 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
pbutils: update for discoverer API changes in last gst-plugins-base pre-release (4.10 KB, patch)
2010-10-30 15:28 UTC, Tim-Philipp Müller
committed Details | Review

Description Tim-Philipp Müller 2010-10-30 15:28:03 UTC
Created attachment 173557 [details] [review]
pbutils: update for discoverer API changes in last gst-plugins-base pre-release

+++ This bug was initially created as a clone of Bug #633311 +++

Use GstDiscoverer{Audio,Video}Info in getters like
gst_discoverer_{audio,video}_info_get_*(). This avoids the casts in the macros,
help language bindings and is more correct.

Also rename _get_is_image() to _is_image() and _get_interlaced() to _is_interlaced().
Comment 1 Tim-Philipp Müller 2010-10-30 15:31:10 UTC
Note: not tested at all really. (Also, unrelated, 'make check' fails for me in gst-python/testsuite/test_bin.py", line 174, in testFake.)
Comment 2 Tim-Philipp Müller 2010-11-01 11:06:25 UTC
I've pushed this, since it breaks e.g. pitivi and the patch reportedly fixes that:

<thiblahute>  Hello, I just recompiled gstreamer using jhbuild (I got some issue with gst-plugin-bad and had to desactivate -Werror), and am trying to launch pitivi now, but am getting:

Traceback (most recent call last):
  • File "bin/pitivi", line 138 in <module>
    _run_pitivi()
  • File "bin/pitivi", line 131 in _run_pitivi
    import pitivi.application as ptv
  • File "pitivi/application.py", line 51 in <module>
    from pitivi.ui.mainwindow import PitiviMainWindow
  • File "pitivi/ui/mainwindow.py", line 32 in <module>
    import gst.pbutils
ImportError: /home/thiblahute/src/gstreamer/install/lib/python2.6/site-packages/gst-0.10/gst/pbutils.so: undefined symbol: gst_discoverer_video_info_get_interlaced

Any idea what is wrong?

<__tim> thiblahute, the API was changed in gst-plugins-base git, gst-python git needs updating for that
<__tim> thiblahute, https://bugzilla.gnome.org/show_bug.cgi?id=633555
<thiblahute> __tim: Ok, I am going to have a look at it then.
<thiblahute> __tim: Works perfectly with the patch, is it closed to be applied?


commit 366f1650a510faf6d80f7d856432d4c839196ae2
Author: Tim-Philipp Müller <tim.muller@collabora.co.uk>
Date:   Sat Oct 30 16:18:59 2010 +0100

    pbutils: update for discoverer API changes in last gst-plugins-base pre-release
    
    https://bugzilla.gnome.org/show_bug.cgi?id=633311