After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 631486 - Adapt to GTK+3 Rendering Cleanup
Adapt to GTK+3 Rendering Cleanup
Status: RESOLVED FIXED
Product: gnome-utils
Classification: Deprecated
Component: general
trunk
Other All
: Normal normal
: ---
Assigned To: gnome-utils Maintainers
gnome-utils Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-10-06 02:30 UTC by Javier Jardón (IRC: jjardon)
Modified: 2010-10-20 21:21 UTC
See Also:
GNOME target: 3.0
GNOME version: ---

Attachments
screenshot: Port to "draw" vfunc (3.36 KB, patch)
2010-10-06 02:32 UTC, Javier Jardón (IRC: jjardon) 		needs-work Details | Review
screenshot: Use accessor functions instead direct access (3.60 KB, patch)
2010-10-09 14:41 UTC, Javier Jardón (IRC: jjardon) 		committed Details | Review
screenshot: Port to "draw" vfunc (4.01 KB, patch)
2010-10-09 14:41 UTC, Javier Jardón (IRC: jjardon) 		committed Details | Review

Description Javier Jardón (IRC: jjardon) 2010-10-06 02:30:29 UTC 
http://live.gnome.org/GnomeGoals/GTKRenderingCleanup
Comment 1 Javier Jardón (IRC: jjardon) 2010-10-06 02:32:56 UTC 
Created attachment 171802 [details] [review]
screenshot: Port to "draw" vfunc
Comment 2 Paolo Borelli 2010-10-09 13:27:57 UTC 
Review of attachment 171802 [details] [review]:

I cleaned up the build system so that we can port each util incrementally to gtk3, so you'll need to update your patch.

The code change itself looks good to me
Comment 3 Javier Jardón (IRC: jjardon) 2010-10-09 14:41:33 UTC 
Created attachment 172017 [details] [review]
screenshot: Use accessor functions instead direct access
Comment 4 Javier Jardón (IRC: jjardon) 2010-10-09 14:41:59 UTC 
Created attachment 172018 [details] [review]
screenshot: Port to "draw" vfunc
Comment 5 Paolo Borelli 2010-10-09 15:40:45 UTC 
Both patches look good to me.


Btw, I ported baobab.
Comment 6 Javier Jardón (IRC: jjardon) 2010-10-20 16:54:23 UTC 
Comment on attachment 172017 [details] [review]
screenshot: Use accessor functions instead direct access

commit 	1aff4e7e7b8542c3501e042f75ad0c3d131598e9
Comment 7 Javier Jardón (IRC: jjardon) 2010-10-20 16:54:43 UTC 
Comment on attachment 172018 [details] [review]
screenshot: Port to "draw" vfunc

commit 	0a4b9f89f3f7721d9782c936fbfafe52c6d5b315
Comment 8 Paolo Borelli 2010-10-20 21:21:50 UTC 
Javier: please please please make it clear if the patches you submit are not tested at all :(

I (naively?) assumed the port was complete and tested when I said to go ahead and commit.

After you committed it I had to spend the evening actually making the rest of the app work and I am not even sure now if my fixes are all correct