Created attachment 171399 [details] [review]
Use gtk3 draw event instead of expose-event

Created attachment 171400 [details] [review]
Use new gdk-pixbuf header

Created attachment 171401 [details] [review]
Don't use GdkColormap

Created attachment 171402 [details] [review]
Use cairo regions to set input shape

Instead of bitmasks.

Created attachment 171403 [details] [review]
Adapt to GnomeBG API changes

The patches all look fine to me though they'd need testing before applying.

Review of attachment 171399 [details] [review]:

::: plugins/common/gsd-osd-window.c
@@ +311,3 @@
+        window = GSD_OSD_WINDOW (widget);
+
+        gtk_widget_get_allocation (widget, &allocation);

We slightly prefer you to use gtk_widget_get_allocated_width/height instead of gtk_widget_get_allocation

Review of attachment 171400 [details] [review]:

The header is not new at all...

Review of attachment 171401 [details] [review]:

Looks good

Review of attachment 171402 [details] [review]:

::: plugins/common/gsd-osd-window.c
@@ +396,2 @@
         gtk_widget_get_allocation (widget, &allocation);
+        region = cairo_region_create_rectangle (&allocation);

I don't think this is right. We want to ignore all input, so the mask / region should be empty, not a rectangle the size of the widget. I think just doing

region = cairo_region_create ();

will do what we want.

::: plugins/mouse/gsd-locate-pointer.c
@@ +200,3 @@
+  rect.x = 0;
+  rect.y = 0;
+  region = cairo_region_create_rectangle (&rect);

Same comment here: I think the region is supposed to be empty.

Review of attachment 171403 [details] [review]:

Looks good

Pushed with those fixes.  Thanks.