After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 630974 - Port to GTK3
Port to GTK3
Status: RESOLVED FIXED
Product: libgnomekbd
Classification: Core
Component: Drawing
unspecified
Other Linux
: Normal normal
: ---
Assigned To: libgnomekbd maintainers
Sergey V. Udaltsov
Depends on:
Blocks: 630874
 
 
Reported: 2010-09-30 01:39 UTC by William Jon McCann
Modified: 2010-10-03 17:42 UTC
See Also:
GNOME target: 3.0
GNOME version: ---


Attachments
Use new GTK3 drawing APIs (5.23 KB, patch)
2010-09-30 01:41 UTC, William Jon McCann
committed Details | Review
Add build dependency on gtk3 (1.15 KB, patch)
2010-09-30 01:41 UTC, William Jon McCann
committed Details | Review
Replace GDK_keyname with GDK_KEY_keyname (5.68 KB, patch)
2010-09-30 01:41 UTC, William Jon McCann
committed Details | Review
Drop GTK_OBJECT usage (1.80 KB, patch)
2010-09-30 01:41 UTC, William Jon McCann
rejected Details | Review
Remove GDK_DISPLAY() usage (2.76 KB, patch)
2010-09-30 01:41 UTC, William Jon McCann
committed Details | Review

Description William Jon McCann 2010-09-30 01:39:01 UTC
Here are some patches to port the library to the latest gtk3 build.  I haven't really tested these changes yet.  But it builds.  Probably needs some review from someone more familiar with the 2->3 changes.
Comment 1 William Jon McCann 2010-09-30 01:41:42 UTC
Created attachment 171394 [details] [review]
Use new GTK3 drawing APIs
Comment 2 William Jon McCann 2010-09-30 01:41:44 UTC
Created attachment 171395 [details] [review]
Add build dependency on gtk3
Comment 3 William Jon McCann 2010-09-30 01:41:47 UTC
Created attachment 171396 [details] [review]
Replace GDK_keyname with GDK_KEY_keyname
Comment 4 William Jon McCann 2010-09-30 01:41:49 UTC
Created attachment 171397 [details] [review]
Drop GTK_OBJECT usage
Comment 5 William Jon McCann 2010-09-30 01:41:50 UTC
Created attachment 171398 [details] [review]
Remove GDK_DISPLAY() usage
Comment 6 Ray Strode [halfline] 2010-09-30 14:00:03 UTC
Comment on attachment 171397 [details] [review]
Drop GTK_OBJECT usage

svu already beat you to this one in commit
b1079544e9585ee01b31b6e882afceb4aac938da
Comment 7 Sergey V. Udaltsov 2010-10-01 20:08:22 UTC
Review of attachment 171398 [details] [review]:

Trivial, clean straightforward. Committed.
Comment 8 Sergey V. Udaltsov 2010-10-01 20:11:12 UTC
Review of attachment 171396 [details] [review]:

Committed, thanks.
Comment 9 Sergey V. Udaltsov 2010-10-01 20:19:12 UTC
Thanks, I committed a couple of patches. 2 questions:
1. What's about rendering? Is the current code using deprecated API?
2. Why dependency on 2.90 if my current 2.22 have all those APIs already?
Comment 10 William Jon McCann 2010-10-01 20:51:24 UTC
(In reply to comment #9)
> Thanks, I committed a couple of patches. 2 questions:
> 1. What's about rendering? Is the current code using deprecated API?
> 2. Why dependency on 2.90 if my current 2.22 have all those APIs already?

Regarding 2) maybe Matthias can instruct us here but I wanted to ensure it was going to link to gtk3 since gtk2 and 3 are parallel installed.
Comment 11 Sergey V. Udaltsov 2010-10-01 21:13:15 UTC
Ghm, what happens if people want gnome2 env and some gtk3 apps? Will they have to install libgnomekbd linked with gtk2?

Was there any discussions to make libs "universal" so that they could use "whatever gtk is around" (if they use interfaces present in both worlds)?
Comment 12 Kjartan Maraas 2010-10-03 09:41:12 UTC
I think the only problem left in here is the use of GdkPixmap here:

struct _GkbdKeyboardDrawing {
        /*< private > */

        GtkDrawingArea parent;

        GdkPixmap *pixmap;

What's the right thing to replace that with?
Comment 13 Kjartan Maraas 2010-10-03 09:45:26 UTC
Oh, I see that's what the first patch is about. Sorry for the noise.
Comment 14 Sergey V. Udaltsov 2010-10-03 17:08:45 UTC
Review of attachment 171394 [details] [review]:

Grand, committed, thanks!
Comment 15 Sergey V. Udaltsov 2010-10-03 17:42:30 UTC
Review of attachment 171395 [details] [review]:

committed
Comment 16 Sergey V. Udaltsov 2010-10-03 17:42:57 UTC
Everything is in git now. Thanks a bunch!