After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 630970 - drop GtkObject use
drop GtkObject use
Status: RESOLVED FIXED
Product: libwnck
Classification: Core
Component: general
2.30.x
Other All
: Normal normal
: ---
Assigned To: libwnck maintainers
libwnck maintainers
Depends on:
Blocks: 630874
 
 
Reported: 2010-09-30 00:32 UTC by Javier Jardón (IRC: jjardon)
Modified: 2010-10-01 00:16 UTC
See Also:
GNOME target: 3.0
GNOME version: ---

Attachments
drop GtkObject use (2.44 KB, patch)
2010-09-30 00:34 UTC, Javier Jardón (IRC: jjardon) 		rejected Details | Review
drop GtkObject use.v2 (2.44 KB, patch)
2010-09-30 17:09 UTC, Javier Jardón (IRC: jjardon) 		none Details | Review
drop GtkObject use.v3 (2.46 KB, patch)
2010-09-30 17:38 UTC, Javier Jardón (IRC: jjardon) 		committed Details | Review

Description Javier Jardón (IRC: jjardon) 2010-09-30 00:32:51 UTC 
GtkObject is gone in GTK3. See http://live.gnome.org/GnomeGoals/GtkObjectRemoval
Comment 1 Javier Jardón (IRC: jjardon) 2010-09-30 00:34:42 UTC 
Created attachment 171384 [details] [review]
drop GtkObject use
Comment 2 Vincent Untz 2010-09-30 08:45:34 UTC 
This means we need to depend on GTK+ 3, though, doesn't it?
Comment 3 Christian Persch 2010-09-30 16:17:13 UTC 
Using GObjectClass::dispose instead of GtkWidgetClass::destroy would make this work on gtk 2 too.
Comment 4 Javier Jardón (IRC: jjardon) 2010-09-30 17:09:38 UTC 
Created attachment 171444 [details] [review]
drop GtkObject use.v2

Use ->dispose instead
Comment 5 Vincent Untz 2010-09-30 17:23:47 UTC 
This is the exact same patch. Probably wrong file? :-)
Comment 6 Javier Jardón (IRC: jjardon) 2010-09-30 17:38:02 UTC 
Created attachment 171446 [details] [review]
drop GtkObject use.v3

Sorry, here the correct patch
Comment 7 Vincent Untz 2010-09-30 17:44:26 UTC 
Review of attachment 171446 [details] [review]:

Thanks, please commit.
Comment 8 Javier Jardón (IRC: jjardon) 2010-09-30 17:50:55 UTC 
Comment on attachment 171446 [details] [review]
drop GtkObject use.v3

commit 1ff975f0f4c0bacebb70441f3c05fe6377e747ab