After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 630675 - drop GtkObject use
drop GtkObject use
Status: RESOLVED FIXED
Product: brasero
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: 2.26
Assigned To: Brasero maintainer(s)
Brasero maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2010-09-27 02:54 UTC by Matthias Clasen
Modified: 2010-10-04 19:28 UTC
See Also:
GNOME target: 3.0
GNOME version: ---

Attachments
patch (11.59 KB, patch)
2010-09-27 02:54 UTC, Matthias Clasen 		accepted-commit_now Details | Review

Description Matthias Clasen 2010-09-27 02:54:48 UTC 
Created attachment 171156 [details] [review]
patch

GtkObject is gone in GTK3. See http://live.gnome.org/GnomeGoals/GtkObjectRemoval
Comment 1 Luis Medinas 2010-09-27 10:01:01 UTC 
Patch looks good. Please commit to git master
Comment 2 Matthias Clasen 2010-09-27 15:49:37 UTC 
commit 7f700c8d4944830992d7d970e17a4de0f8458338
Author: Matthias Clasen <mclasen@redhat.com>
Date:   Mon Sep 27 11:47:26 2010 -0400

    Adapt to GtkObject removal in GTK3
    
    Most of the changes here move destroy implementations to GtkWidgetClass
    instead of GtkObjectClass, and adapt the destroy signature.
    
    Bug 630675
Comment 3 Matthias Clasen 2010-09-30 19:07:42 UTC 
One thing I forgot to say explicitly is that with this patch, building against gtk2 no longer works. So you should nuke the --with-gtk option. (or add ifdefs to make it work with gtk2 too, but that will get cumbersome soon).
Comment 4 Philippe Rouquier 2010-10-04 19:28:34 UTC 
Thanks that was what I did for master which now requires gtk3 only. I intend to remove the last crufts related gtk2 soon; moreover we just moved to the new rendering scheme and therefore gtk2 switch is no use any more (not without a lot of pain) and I removed it.