After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 630497 - [seek] sprinkle GST_DEBUG_BIN_TO_DOT_FILE_WITH_TS to dump pipeline to dot file
[seek] sprinkle GST_DEBUG_BIN_TO_DOT_FILE_WITH_TS to dump pipeline to dot file
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other All
: Normal enhancement
: 0.10.36
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-09-24 08:46 UTC by Vladimir Eremeev
Modified: 2011-11-07 23:42 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
adds two new buttons (3.59 KB, patch)
2010-09-24 08:46 UTC, Vladimir Eremeev
none Details | Review
Adding one button, to dump dot file (3.18 KB, patch)
2010-11-25 08:57 UTC, Vladimir Eremeev
needs-work Details | Review

Description Vladimir Eremeev 2010-09-24 08:46:09 UTC
Created attachment 171007 [details] [review]
adds two new buttons

Two useful buttons: 
- go end button, which shows the very last movie frame
- dump .dot button, which saves the current pipeline to the .dot file, provided
the respective environment variable is set.
Comment 1 Wim Taymans 2010-09-24 14:37:07 UTC
That's not quite right, a seek to the duration of a file should post EOS immediately without decoding any frames.
Comment 2 Vladimir Eremeev 2010-09-24 14:53:34 UTC
Yes, you're right.
I've added this while was experimenting with my own player, and didn't correct it here. Sorry.

Finally, in my own player, I've come to another solution: 
start the reverse playback and paus the pipeline on GST_STATE_CHANGE.
Comment 3 Vladimir Eremeev 2010-11-25 08:57:05 UTC
Created attachment 175224 [details] [review]
Adding one button, to dump dot file

Seek to end of file needs more work yet.
Comment 4 Sebastian Dröge (slomo) 2011-05-26 08:39:10 UTC
Review of attachment 175224 [details] [review]:

::: tests/examples/seek/seek.c
@@ +39,3 @@
 #ifdef G_OS_WIN32
 #include <gdk/gdkwin32.h>
+#include <direct.h>

Why do you add this new header?

@@ +1741,3 @@
+      if(g_setenv("GST_DEBUG_DUMP_DOT_DIR",(const gchar*)getcwd(cwd,MAXPATHLEN),TRUE))
+        GST_DEBUG("GST_DEBUG_DUMP_DOT_DIR=%s",g_getenv("GST_DEBUG_DUMP_DOT_DIR"));
+      g_free(cwd);

You should use g_get_current_dir(), which returns a newly allocated string in the correct encoding
Comment 5 Tim-Philipp Müller 2011-05-26 09:09:39 UTC
I don't think we need a button to dump the dot file, just add a few GST_DEBUG_BIN_TO_DOT_FILE_WITH_TS() in strategic places (prerolled, error) and let the user set the DOT_DIR to get them dumped.
Comment 6 Vladimir Eremeev 2011-05-26 09:22:13 UTC
> Why do you add this new header?
Sorry, it's a typo. It should read 
#include <dirent.h>

> You should use g_get_current_dir(),
Yes, that's better, agree.
Comment 7 Stefan Sauer (gstreamer, gtkdoc dev) 2011-07-27 11:18:20 UTC
I agree with tim, having UI only makes sense if you e.g. allow to configure the details (flags).

Vladimir, are you interested in changing your patch to add the GST_DEBUG_BIN_TO_DOT_FILE_WITH_TS() macros as tim suggested.
Comment 8 Vladimir Eremeev 2011-07-27 11:36:40 UTC
It seems to me, this example GUI application allows setting flags, no?
It has several checkboxes.
Sorry, I don't remember exactly, this was rather long time ago. 

If I am wrong, then Tim's suggestion is reasonable, and I agree with it.
Comment 9 Stefan Sauer (gstreamer, gtkdoc dev) 2011-07-27 13:48:40 UTC
Vladimir, I am not talking about seek flags, but the flags for the pipeline dumping.
Comment 10 Vladimir Eremeev 2011-07-27 14:03:00 UTC
Ah, yes, now I see.
Then, I agree with Tim's suggestion, macros would be enough.
Comment 11 Akhil Laddha 2011-11-02 07:01:16 UTC
Vladimir, do you have any update for the bug ?
Comment 12 Vladimir Eremeev 2011-11-02 07:09:37 UTC
No.
I don't currently do any work, related to the GStreamer, so don't have any updates.

I also thought that this bug was resolved.
Comment 13 Tim-Philipp Müller 2011-11-07 23:42:29 UTC
commit c6c6c2e75e57e827418e9f7ff2db55c544736884
Author: Tim-Philipp Müller <tim.muller@collabora.co.uk>
Date:   Mon Nov 7 23:41:33 2011 +0000

    examples: sprinkle GST_DEBUG_BIN_TO_DOT_FILE_WITH_TS in seek test utility
    
    https://bugzilla.gnome.org/show_bug.cgi?id=630497