After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 630447 - rtpsession: relax third-party collision detection
rtpsession: relax third-party collision detection
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
unspecified
Other All
: Normal normal
: 0.10.26
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-09-23 17:52 UTC by Håvard Graff (hgr)
Modified: 2010-09-24 11:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (1.52 KB, patch)
2010-09-23 17:52 UTC, Håvard Graff (hgr) 		reviewed Details | Review

Description Håvard Graff (hgr) 2010-09-23 17:52:21 UTC 
Created attachment 170944 [details] [review]
patch

...
Comment 1 Olivier Crête 2010-09-23 19:07:04 UTC 
Review of attachment 170944 [details] [review]:

::: gst/rtpmanager/rtpsession.c
@@ +1109,3 @@
+    if (arrival->time > source->last_activity) {
+      GstClockTime inactivity_period = arrival->time - source->last_activity;
+      if (inactivity_period > 1*GST_SECOND) {

You could do that instead:
if (arrival->time > source->last_activity && arrival->time - source->last_activity > 1 * GST_SECOND) {

Otherwise it looks good to me. Btw, the "favor-new" property is probably want you want to use too ?
Comment 2 Wim Taymans 2010-09-24 11:58:03 UTC 
commit 062568a9f53632b6bca5803d2d381741fc387b1d
Author: Havard Graff <havard.graff@tandberg.com>
Date:   Mon Aug 31 18:37:40 2009 +0200

    rtpsession: relax third-party collision detection
    
    If the source has been inactive for some time, we assume that it has
    simply changed its transport source address. Hence, there is no true
    third-party collision - only a simulated one.
    
    Fixes #630447