After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 629604 - packagekit doesn't work for me
packagekit doesn't work for me
Status: RESOLVED FIXED
Product: file-roller
Classification: Applications
Component: general
2.31.x
Other Linux
: Normal normal
: ---
Assigned To: Paolo Bacchilega
file-roller-maint
Depends on:
Blocks:
 
 
Reported: 2010-09-14 02:28 UTC by Pablo Castellano (IRC: pablog)
Modified: 2010-09-15 13:32 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
packagekit-fileroller.gif (19.29 KB, image/gif)
2010-09-14 02:28 UTC, Pablo Castellano (IRC: pablog) 		Details

Description Pablo Castellano (IRC: pablog) 2010-09-14 02:28:27 UTC 
I wanted to test the packagekit support but I get the following error in the console:

(file-roller:30904): GLib-GIO-CRITICAL **: g_dbus_message_set_signature: assertion `value == NULL || g_variant_is_signature (value)' failed


And an error messagebox (see attached image)
Comment 1 Pablo Castellano (IRC: pablog) 2010-09-14 02:28:43 UTC 
Created attachment 170213 [details]
packagekit-fileroller.gif
Comment 2 Pablo Castellano (IRC: pablog) 2010-09-14 03:55:03 UTC 
well, it's because packagekit wasn't running in my dbus session, but message error isn't very helpful :?
Comment 3 Paolo Bacchilega 2010-09-14 07:27:40 UTC 
that message is returned by DBus, but using the error type we could display a more meaningful message.
Comment 4 Christian Persch 2010-09-14 09:05:59 UTC 
The code is buggy:

                        g_dbus_proxy_call (proxy,
                                           "InstallPackageNames",
                                           g_variant_new ("(u^asms)",
                                                          xid,
                                                          names,
                                                          "hide-confirm-search,hide-finished,hide-warning"),

dbus doesn't support "m" types yet, AND the service doesn't even use "m" here! The signature must be (u^ass).
Comment 5 Paolo Bacchilega 2010-09-14 11:50:34 UTC 
..and the timeout must be disabled using G_MAXINT instead of -1
Comment 6 Paolo Bacchilega 2010-09-15 12:06:30 UTC 
This is now fixed in current master, thank you.  

(The commit was approved by the release team)
Comment 7 Pablo Castellano (IRC: pablog) 2010-09-15 13:32:51 UTC 
Cool!

One last thing missing is that the message title "Could not create the archive" is not appropriate. But that implies a string change and is not a big issue.