After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 629535 - gnome-panel crashes when exiting
gnome-panel crashes when exiting
Status: RESOLVED FIXED
Product: gnome-panel
Classification: Other
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Panel Maintainers
Panel Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-09-13 15:44 UTC by Ray Strode [halfline]
Modified: 2010-09-13 15:57 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
use load_all_dirs instead of scan_all_dirs since the former implicitly refs each module (34.50 KB, patch)
2010-09-13 15:44 UTC, Ray Strode [halfline]
committed Details | Review

Description Ray Strode [halfline] 2010-09-13 15:44:16 UTC
Created attachment 170170 [details] [review]
use load_all_dirs instead of scan_all_dirs since the former implicitly refs each module

We have a large number of fedora reports where gnome-panel is crashing when exiting.  I did a quick search over bugzilla but couldn't find any existing report.  Presumably that's because no one notices it crashing since they're logging out anyway.

The important part of the stack trace is here:

Thread 1 (Thread 1673)

  • #0 ??
  • #1 __run_exit_handlers
    at exit.c line 78
  • #2 exit
    at exit.c line 100
  • #3 __libc_start_main
    at libc-start.c line 258
  • #4 _start


The function at address 0x000000383bc4c500 is no longer mapped.  This is because it's from libbonoboui which is only linked from a plugin that gets unloaded before exit (libbonoboui installed an atexit handler).

gnome-panel probably shouldn't allow plugins to be unmapped after being loaded.  Aside from atexit() handlers, I think any reasonable plugin is going to use static types and other things that won't behave well either.
Comment 1 Ray Strode [halfline] 2010-09-13 15:56:28 UTC
Well attachment 170170 [details] [review] was obviously garbage-from-a-wget-gone-wrong, but I've talked to vuntz on irc and committed the real patch anyway:

http://git.gnome.org/browse/gnome-panel/commit/?id=0ace553ed8b0a28ac538c4d970dbe7a6d52d7529