After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 629349 - [oggdemux] extract stream tags for tagreadbin and transcoding
[oggdemux] extract stream tags for tagreadbin and transcoding
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
unspecified
Other Linux
: Normal enhancement
: 0.10.32
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-09-11 10:35 UTC by Felipe Contreras (banned)
Modified: 2010-12-03 13:07 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
oggdemux: generate tags for all types (1.28 KB, patch)
2010-09-11 10:36 UTC, Felipe Contreras (banned)
none Details | Review
oggdemux: delay tag messages after pad activatio (2.92 KB, patch)
2010-09-11 10:36 UTC, Felipe Contreras (banned)
none Details | Review
flacparse: trivial caps fix (787 bytes, patch)
2010-09-11 10:36 UTC, Felipe Contreras (banned)
none Details | Review
flacparse: delay tags push (1.61 KB, patch)
2010-09-11 10:37 UTC, Felipe Contreras (banned)
none Details | Review
patch for vorbis comment extraction (9.64 KB, patch)
2010-09-14 21:46 UTC, sreerenj
committed Details | Review
oggdemux: send stream tags after newsegment and global tags (1.51 KB, patch)
2010-10-27 12:12 UTC, Mark Nauwelaerts
committed Details | Review
oggstream: streamline tags extraction and prevent some leaks (3.95 KB, patch)
2010-10-27 12:13 UTC, Mark Nauwelaerts
committed Details | Review
oggdemux: plug some oggstream leaks (909 bytes, patch)
2010-10-27 12:13 UTC, Mark Nauwelaerts
committed Details | Review
oggstream: refactor vorbis comment packet tag extraction (4.95 KB, patch)
2010-10-27 12:14 UTC, Mark Nauwelaerts
committed Details | Review
oggstream: use separate tag extraction vfunction (8.11 KB, patch)
2010-10-27 12:14 UTC, Mark Nauwelaerts
committed Details | Review
oggstream: additional types tag extraction (2.89 KB, patch)
2010-10-27 12:15 UTC, Mark Nauwelaerts
committed Details | Review

Description Felipe Contreras (banned) 2010-09-11 10:35:35 UTC
Here's a bunch of fixes to oggdemux/flacparse for tagreadbin.
Comment 1 Felipe Contreras (banned) 2010-09-11 10:36:13 UTC
Created attachment 170016 [details] [review]
oggdemux: generate tags for all types
Comment 2 Felipe Contreras (banned) 2010-09-11 10:36:40 UTC
Created attachment 170017 [details] [review]
oggdemux: delay tag messages after pad activatio
Comment 3 Felipe Contreras (banned) 2010-09-11 10:36:57 UTC
Created attachment 170018 [details] [review]
flacparse: trivial caps fix
Comment 4 Felipe Contreras (banned) 2010-09-11 10:37:16 UTC
Created attachment 170019 [details] [review]
flacparse: delay tags push
Comment 5 Tim-Philipp Müller 2010-09-11 10:46:31 UTC
Re. the oggdemux patch, I think the tag extraction should be done in gstoggstream.c, since tags are in header packets, and header packets are parsed there. The existing ogm stuff in chain_peer should be moved there as well IMHO.

Moving to gst-plugins-base component for now, as gst-plugins is for old 0.8 bugs and no one checks those.

On a side note, this is not just for tagreadbin, but useful in general, e.g. for stream extraction (flac audio into stand-alone flac) or transcoding.
Comment 6 Felipe Contreras (banned) 2010-09-13 13:43:19 UTC
(In reply to comment #5)
> Re. the oggdemux patch, I think the tag extraction should be done in
> gstoggstream.c, since tags are in header packets, and header packets are parsed
> there. The existing ogm stuff in chain_peer should be moved there as well IMHO.

Maybe, but that would be a separate bug report/patch.
Comment 7 sreerenj 2010-09-14 09:53:34 UTC
(In reply to comment #5)
> Re. the oggdemux patch, I think the tag extraction should be done in
> gstoggstream.c, since tags are in header packets, and header packets are parsed
> there. The existing ogm stuff in chain_peer should be moved there as well IMHO.
> 
> Moving to gst-plugins-base component for now, as gst-plugins is for old 0.8
> bugs and no one checks those.
> 
> On a side note, this is not just for tagreadbin, but useful in general, e.g.
> for stream extraction (flac audio into stand-alone flac) or transcoding.


Currently we are parsing only the identification header in gstoggstream.c. I think we can add the comment header parsing for ogm,vorbis and vp8 to header checking functions of each(is_header_ogm,is_header_vorbis and is_header_vp8) .
Comment 8 sreerenj 2010-09-14 21:46:48 UTC
Created attachment 170291 [details] [review]
patch for vorbis comment extraction 

* Moving  the tag extraction to gstoggstream.c.
* Maintaining the taglist in GstOggStream structure.
* Extracting few more identification header fields as tags.
Comment 9 Tim-Philipp Müller 2010-10-04 00:11:29 UTC
Comment on attachment 170019 [details] [review]
flacparse: delay tags push

See bug #631200
Comment 10 Tim-Philipp Müller 2010-10-04 00:11:34 UTC
Comment on attachment 170018 [details] [review]
flacparse: trivial caps fix

See bug #631200
Comment 11 Mark Nauwelaerts 2010-10-27 12:11:15 UTC
Some (cumulative) patches follow that refactor, extend etc tag extraction in oggdemux/oggstream as initiated by last patch.
Comment 12 Mark Nauwelaerts 2010-10-27 12:12:45 UTC
Created attachment 173315 [details] [review]
oggdemux: send stream tags after newsegment and global tags
Comment 13 Mark Nauwelaerts 2010-10-27 12:13:22 UTC
Created attachment 173317 [details] [review]
oggstream: streamline tags extraction and prevent some leaks
Comment 14 Mark Nauwelaerts 2010-10-27 12:13:48 UTC
Created attachment 173318 [details] [review]
oggdemux: plug some oggstream leaks
Comment 15 Mark Nauwelaerts 2010-10-27 12:14:25 UTC
Created attachment 173319 [details] [review]
oggstream: refactor vorbis comment packet tag extraction
Comment 16 Mark Nauwelaerts 2010-10-27 12:14:58 UTC
Created attachment 173320 [details] [review]
oggstream: use separate tag extraction vfunction
Comment 17 Mark Nauwelaerts 2010-10-27 12:15:57 UTC
Created attachment 173321 [details] [review]
oggstream: additional types tag extraction
Comment 18 Mark Nauwelaerts 2010-12-03 13:05:56 UTC
commit 524b7c60f20336aef6266ed260134188e7102c8e
Author: Mark Nauwelaerts <mark.nauwelaerts@collabora.co.uk>
Date:   Wed Oct 27 13:49:41 2010 +0200

    oggstream: additional tag extraction
    
    ... supporting theora, flac, speex, celt.
    
    Fixes #629349.

commit d5055a9f23c64a1f6b13c690e61ba70f3d50d58a
Author: Mark Nauwelaerts <mark.nauwelaerts@collabora.co.uk>
Date:   Wed Oct 27 12:08:25 2010 +0200

    oggstream: use separate tag extraction vfunction

commit cc3dfd31d09f04d970a9fb9862786312694dbe87
Author: Mark Nauwelaerts <mark.nauwelaerts@collabora.co.uk>
Date:   Wed Oct 27 11:58:53 2010 +0200

    oggstream: refactor vorbis comment tag extraction

commit a4aacb9d2c3877e965fd6f9ee9c48a07cbcbec0c
Author: Mark Nauwelaerts <mark.nauwelaerts@collabora.co.uk>
Date:   Wed Oct 27 11:16:15 2010 +0200

    oggdemux: plug some oggstream leaks

commit 515f33bd3bc1f4e6bd1ccad5f6d55fb592a534ec
Author: Mark Nauwelaerts <mark.nauwelaerts@collabora.co.uk>
Date:   Wed Oct 27 10:59:03 2010 +0200

    oggstream: streamline tag extraction and prevent some leaks

commit 63ba9eafb13ef8b6a28a1a8baa39376eabe5bba1
Author: Mark Nauwelaerts <mark.nauwelaerts@collabora.co.uk>
Date:   Wed Oct 27 10:58:16 2010 +0200

    oggdemux: send stream tags after newsegment and global tags

commit 2319c85f469b92221dd86e9d89dda268a8a127b4
Author: Sreerenj Balachandran <sreerenj.balachandran@nokia.com>
Date:   Tue Sep 14 23:08:51 2010 +0300

    oggdemux: perform more (vorbis comment header) tag extractions
    
    In particular, move comment header parsing to gstoggstrem.c.
    Thanks to Felipe Contreras.
    
    Fixes #629349 (partially).