After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 629300 - gstructure: New API for comparing structures
gstructure: New API for comparing structures
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
unspecified
Other All
: Normal enhancement
: 0.10.36
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-09-10 16:15 UTC by Edward Hervey
Modified: 2011-06-15 17:28 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
gstructure: New API: gst_structure_is_equal (4.49 KB, patch)
2010-09-10 16:15 UTC, Edward Hervey
committed Details | Review
gststructure: Add gst_structure_can_intersect API (5.72 KB, patch)
2010-09-10 16:35 UTC, Edward Hervey
committed Details | Review

Description Edward Hervey 2010-09-10 16:15:38 UTC
Allows checking equality of GstStructure without having to create
intermediary GstCaps.

API: gst_structure_is_equal
Comment 1 Edward Hervey 2010-09-10 16:15:41 UTC
Created attachment 169968 [details] [review]
gstructure: New API: gst_structure_is_equal
Comment 2 Edward Hervey 2010-09-10 16:35:07 UTC
Created attachment 169971 [details] [review]
gststructure: Add gst_structure_can_intersect API

Allows checking if two structures can intersect without having to
go through GstCaps

API: gst_structure_can_intersect
Comment 3 Sebastian Dröge (slomo) 2010-09-10 18:58:13 UTC
Makes sense but maybe add a gst_structure_intersect() too while we're at it :)

Patches look good (of course)
Comment 4 Stefan Sauer (gstreamer, gtkdoc dev) 2010-09-24 10:38:33 UTC
Looks good. Out of curiosity, where do you need it?
Comment 5 Sebastian Dröge (slomo) 2011-05-09 10:15:20 UTC
Comment on attachment 169968 [details] [review]
gstructure: New API: gst_structure_is_equal

Please push this after the release, thanks ;) And if you want to make me more happy please add gst_structure_intersection()
Comment 6 Stefan Sauer (gstreamer, gtkdoc dev) 2011-05-09 11:54:39 UTC
(In reply to comment #5)
> (From update of attachment 169968 [details] [review])
> Please push this after the release, thanks ;) And if you want to make me more
> happy please add gst_structure_intersection()

gst_caps_structure_intersect() - we could move that from gstcaps.c to gststructure.c, rename to gst_structure_intersect() and make it public.
Comment 7 Sebastian Dröge (slomo) 2011-05-17 07:36:58 UTC
commit b4dea3a1d3133b9a94ffdaba5122a59cdae9cf9c
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Tue May 17 09:35:54 2011 +0200

    structure: Make both parameters to gst_structure_is_equal() const

commit 53ef31718d7e53f9b8f76c74fd5c7441a0398c0f
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Tue May 17 09:33:47 2011 +0200

    structure: Update Since markers to the correct version

commit a08a17dfbdbe4b5f51856dd6ec85fbe726bfacfb
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Tue May 17 09:33:04 2011 +0200

    structure: Add gst_structure_intersect()
    
    API: gst_structure_intersect()


commit 64725facb5d9b51570096dd3a980b19247372a57
Author: Edward Hervey <bilboed@bilboed.com>
Date:   Fri Sep 10 18:33:34 2010 +0200

    gststructure: Add gst_structure_can_intersect API
    
    Allows checking if two structures can intersect without having to
    go through GstCaps
    
    API: gst_structure_can_intersect
    
    https://bugzilla.gnome.org/show_bug.cgi?id=629300

commit ae46eb3a3848fa5991e987f08d59bc6a5b2bc9b5
Author: Edward Hervey <bilboed@bilboed.com>
Date:   Fri Sep 10 18:14:05 2010 +0200

    gstructure: New API: gst_structure_is_equal
    
    Allows checking equality of GstStructure without having to create
    intermediary GstCaps.
    
    API: gst_structure_is_equal
    
    https://bugzilla.gnome.org/show_bug.cgi?id=629300