After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 629046 - Empty reply quotation for HTML messages
Empty reply quotation for HTML messages
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Mailer
2.30.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: evolution-mail-maintainers
Evolution QA team
: 633151 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2010-09-08 11:27 UTC by Milan Crha
Modified: 2011-03-01 11:00 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
test email (1.51 KB, text/plain)
2010-09-08 11:27 UTC, Milan Crha
  Details
evo patch (618 bytes, patch)
2010-09-09 07:37 UTC, Milan Crha
committed Details | Review

Description Milan Crha 2010-09-08 11:27:52 UTC
Created attachment 169758 [details]
test email

Moving this from a downstream bugzilla:
https://bugzilla.redhat.com/show_bug.cgi?id=629119

Long story short:
Having set in Mail Preferences, HTML Messages tab:
   [x] Show suppressed HTML parts as attachments

   [ Show plain text if present | v ]

and in Composer Preferences, 
   [ ] Format messages as HTML
   ...
   Reply style: [ Quoted | v ]


then using the attached message and replying to it will create an empty body, with no quotation - body will contain only a line:
   On Wed, 2010-09-08 at 13:22 +0200, zyx wrote:
and nothing else. This is doing it either when the message preview is on, or from a message window (double-clicking on the message itself), otherwise it does the correct thing too (with no preview pane).

Unchecking "Show suppressed HTML parts as attachments" will let this work as expected with a preview pane too.
Comment 1 Paul Menzel 2010-09-08 21:40:26 UTC
This issue is tracked as #596156 in the Debian BTS [1].

[1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=596156
Comment 2 Milan Crha 2010-09-09 07:37:32 UTC
Created attachment 169832 [details] [review]
evo patch

for evolution;

multipart/alternative is processed in a way to pick the best format evolution can show and use it. The prefer plain plugin modifies the original message in a way that for the above mentioned setup the best part, the html one, is marked as an attachment, which the formatter denied to format, because it skips attachments when formatting. So avoiding to pick the attachment part as the best part for multipart/alternative fixes the issue.

It has also a little side-effect, because when having set to not showing HTML parts, and having the prefer-plain plugin set to format them as attachment, the message reply is constructed from a text/plain part, where not making HTML parts as attachment formats reply body from the HTML part. I believe this is a very nice side-effect. (It's partly fixing bug #481915 too.)
Comment 3 Milan Crha 2010-09-09 07:38:46 UTC
Created commit 19fb229 in evo master (2.31.92+)
Comment 4 Milan Crha 2011-01-20 11:37:52 UTC
*** Bug 633151 has been marked as a duplicate of this bug. ***
Comment 5 Paul Menzel 2011-03-01 11:00:09 UTC
To confirm, this is fixed in 2.32.x. I cannot reproduce this problem with the backported patch to Evolution 2.30.3-3 in Debian Squeeze/stable or with Evolution 2.32.2 in Debian Sid/unstable.