After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 627992 - dtmfsrc doesn't support gst_element_send_event
dtmfsrc doesn't support gst_element_send_event
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 0.10.21
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-08-26 03:07 UTC by Youness Alaoui
Modified: 2010-09-06 11:42 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Youness Alaoui 2010-08-26 03:07:30 UTC
The doc says to use gst_element_send_event on the pipeline, but if
we are to call it on the element itself, it doesn't work.
This patch will make the dtmfsrc support receiving events through gst_element_send_event when it's called directly on it.
Patch available here : http://git.collabora.co.uk/?p=user/kakaroto/gst-plugins-bad.git;a=commitdiff;h=98d2c94f7430f977c9c0a4a48001a36549e20e99
Comment 1 Olivier Crête 2010-08-26 16:17:49 UTC
This looks good, will commit after freeze.
Comment 2 Sebastian Dröge (slomo) 2010-08-30 13:18:40 UTC
send_event() defaults to sending to a random pad of the correct direction so this shouldn't be necessary
Comment 3 Wim Taymans 2010-08-30 13:21:11 UTC
(In reply to comment #2)
> send_event() defaults to sending to a random pad of the correct direction so
> this shouldn't be necessary

basesrc overrides the default handler and ignores CUSTOM events, so you need to manually override for now (also see FIXME in basesrc).
Comment 4 Tim-Philipp Müller 2010-09-06 10:03:31 UTC
> This looks good, will commit after freeze.

That would be now
Comment 5 Olivier Crête 2010-09-06 11:42:29 UTC
Committed:

commit 9823b9358e1a188dafb43fc29f00fa81e1745ced
Author: Youness Alaoui <youness.alaoui@collabora.co.uk>
Date:   Thu Aug 26 02:54:55 2010 -0400

    dtmfsrc: Make the dtmfsrc accept events sent with gst_element_send_event
    
    The doc says to use gst_element_send_event on the pipeline, but if
    we are to call it on the element itself, it's a noop. This should make it
    handle the event properly before delegating it to basesrc.