After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 627991 - rtpmux will freeze whenever a flush is sent
rtpmux will freeze whenever a flush is sent
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal blocker
: 0.10.20
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-08-26 03:05 UTC by Youness Alaoui
Modified: 2010-08-30 13:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
rptmux patch (1.01 KB, patch)
2010-08-26 20:08 UTC, Youness Alaoui 		committed Details | Review

Description Youness Alaoui 2010-08-26 03:05:41 UTC 
A bad typo in the GST_OBJECT_UNLOCK for the FLUSH_STOP case of rtpmux make it freeze whenever it tries to get the lock the next time.
Here's the patch : http://git.collabora.co.uk/?p=user/kakaroto/gst-plugins-bad.git;a=commitdiff;h=8070c2e825cf8494e7f592e7cbdfac8418801bce
Comment 1 Olivier Crête 2010-08-26 16:17:39 UTC 
This looks good, will commit after freeze (unless someone wants to commit it now).
Comment 2 Olivier Crête 2010-08-26 19:46:56 UTC 
Can we get this before the next release actually ? It's a pretty obvious bugfix.
Comment 3 Youness Alaoui 2010-08-26 20:08:33 UTC 
Created attachment 168838 [details] [review]
rptmux patch

Here's a proper patch attached. Please apply.
Comment 4 Sebastian Dröge (slomo) 2010-08-30 13:22:10 UTC 
commit 5cc57a82f079d50a5f6daa8601e44fea3e7631eb
Author: Youness Alaoui <youness.alaoui@collabora.co.uk>
Date:   Wed Aug 25 22:56:03 2010 -0400

    rtpmux: Unlock the right mutex
    
    The mutex locked is for the 'mux' object, but we unlock the
    pad, which means that if the rtpmux gets a flush, then the
    object lock will stay locked forever, causing it to freeze
    the next time it tries to take it.
    
    Fixes bug #627991