After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 627829 - Workaround for Japanese Shift_JIS conversion problem
Workaround for Japanese Shift_JIS conversion problem
Status: RESOLVED FIXED
Product: libgoffice
Classification: Other
Component: Gtk+
0.8.x
Other All
: Normal normal
: ---
Assigned To: Jody Goldberg
Jody Goldberg
Depends on:
Blocks: 627718
 
 
Reported: 2010-08-24 11:31 UTC by Yasuaki Taniguchi
Modified: 2010-09-24 00:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
CP932 charmap patch (922 bytes, patch)
2010-08-24 11:31 UTC, Yasuaki Taniguchi 		none Details | Review
CP932 csv file that is failed to be imported (65 bytes, text/csv)
2010-09-04 13:12 UTC, Yasuaki Taniguchi 		  Details
Expected behavior, successfully imported (51.53 KB, image/png)
2010-09-04 13:20 UTC, Yasuaki Taniguchi 		  Details
Actual behavior, garbled characters are shown (58.76 KB, image/png)
2010-09-04 13:23 UTC, Yasuaki Taniguchi 		  Details

Description Yasuaki Taniguchi 2010-08-24 11:31:29 UTC 
Created attachment 168631 [details] [review]
CP932 charmap patch

Codepage 932 is a default charset of Windows Japanese version and it consists of the original Shift_JIS plus MS extensions.

Speaking technically, CP932 is different from the original Shift_JIS. CP932 is a superset of Shift_JIS. But many Japanese users and applications (ex. Firefox, Openoffice.org,.. etc.) treat CP932 and Shift_JIS are the same, and call it simply Shift_JIS.

So it is reasonable and convenient for libgoffice to follow the way so as to avoid garbles.

An attached patch is workaround for this problem.
Comment 1 Yasuaki Taniguchi 2010-09-04 13:12:11 UTC 
Created attachment 169484 [details]
CP932 csv file that is failed to be imported
Comment 2 Yasuaki Taniguchi 2010-09-04 13:20:18 UTC 
Created attachment 169485 [details]
Expected behavior, successfully imported
Comment 3 Yasuaki Taniguchi 2010-09-04 13:23:16 UTC 
Created attachment 169486 [details]
Actual behavior, garbled characters are shown
Comment 4 Morten Welinder 2010-09-05 18:24:56 UTC 
Should the label be changed to mention cp932 instead of Shift_JIS?
Would it make sense to have both?

Note, that we will have to take your word for the correctness of this.
None of the Gnumeric regulars have experience with Japanese.
Comment 5 Yasuaki Taniguchi 2010-09-05 20:13:00 UTC 
The label should be kept Shift_JIS. It is *not* necessary to add the CP932 label because many users are not familiar with the word CP932.

When a user specify Shift_JIS, applications should treat it CP932.
Comment 6 Morten Welinder 2010-09-24 00:55:41 UTC 
This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.