After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 627341 - wavparse: strange handling of files less than 12 bytes
wavparse: strange handling of files less than 12 bytes
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
unspecified
Other Linux
: Normal normal
: 0.10.26
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-08-19 08:00 UTC by mersad
Modified: 2010-09-04 13:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
wavparse: Post an error message if EOS happens before valid input is found (1.41 KB, patch)
2010-08-19 10:24 UTC, Sebastian Dröge (slomo) 		committed Details | Review

Description mersad 2010-08-19 08:00:36 UTC 
gst_wavparse_parse_stream_init (): if the file is smaller that 12 bytes, it will not check the file header, and it will return GST_FLOW_OK.

Another problem, seems to be when trying to play an empty text file, gst_wavparse_sink_event () will not receive GST_EVENT_NEWSEGMENT event (in which the file is checked for correctness) and it only receives GST_EVENT_EOS.
Comment 1 Sebastian Dröge (slomo) 2010-08-19 10:24:08 UTC 
Thanks for reporting, I'll push the attached patch after the upcoming release.
Comment 2 Sebastian Dröge (slomo) 2010-08-19 10:24:26 UTC 
Created attachment 168277 [details] [review]
wavparse: Post an error message if EOS happens before valid input is found

Fixes bug #627341.
Comment 3 Sebastian Dröge (slomo) 2010-09-04 13:15:25 UTC 
commit 95f5b494faccf8e858197457256ccf3cb1ef61e6
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Thu Aug 19 12:23:16 2010 +0200

    wavparse: Post an error message if EOS happens before valid input is found
    
    Fixes bug #627341.