After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 626206 - Chart related crash on corrupted chart-tests.gnumeric
Chart related crash on corrupted chart-tests.gnumeric
Status: RESOLVED FIXED
Product: Gnumeric
Classification: Applications
Component: Charting
git master
Other All
: Normal normal
: ---
Assigned To: Jean Bréfort
Jody Goldberg
Depends on:
Blocks:
 
 
Reported: 2010-08-06 14:57 UTC by Morten Welinder
Modified: 2010-08-07 07:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Corrupted file (806.24 KB, application/x-gzip)
2010-08-06 15:03 UTC, Morten Welinder 		  Details
Proposed patch (1.35 KB, patch)
2010-08-06 17:43 UTC, Jean Bréfort 		none Details | Review
A much better patch (1.11 KB, patch)
2010-08-07 06:59 UTC, Jean Bréfort 		committed Details | Review

Description Morten Welinder 2010-08-06 14:57:55 UTC 
../libtool --mode=execute gdb --args ../src/ssconvert 'zzuftmp/ccc-1.xml' 'zzuftmp/ccc-1.gnumeric'
[...]
Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7f64e98ca6f0 (LWP 17644)]
0x00007f64e8f74e38 in gog_series_init_style (gso=0xa36470, style=0x0) at gog-series.c:619
619		style->interesting_fields = series->plot->desc.series.style_fields;
Comment 1 Morten Welinder 2010-08-06 15:03:31 UTC 
Created attachment 167257 [details]
Corrupted file
Comment 2 Jean Bréfort 2010-08-06 17:43:09 UTC 
Created attachment 167265 [details] [review]
Proposed patch
Comment 3 Morten Welinder 2010-08-06 18:46:34 UTC 
I don't mind that patch, but it would appear to just avoid the crash
and not the cause.  Shouldn't we avoid sendinf a NULL style over there
in the first place?
Comment 4 Jean Bréfort 2010-08-07 06:24:15 UTC 
Fully agreed, my patch was quickly written, and is intrisically bad. We should avoid to send a NULL object, and, also, do not accept a NULL pointer in go_styled_object_set_style.
Comment 5 Jean Bréfort 2010-08-07 06:59:59 UTC 
Created attachment 167301 [details] [review]
A much better patch
Comment 6 Jean Bréfort 2010-08-07 07:38:54 UTC 
This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.