After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 625454 - Format classification
Format classification
Status: RESOLVED FIXED
Product: libgoffice
Classification: Other
Component: General
0.8.x
Other Linux
: Normal normal
: ---
Assigned To: Jody Goldberg
Jody Goldberg
Depends on:
Blocks:
 
 
Reported: 2010-07-28 05:16 UTC by Andreas J. Guelzow
Modified: 2010-07-30 17:40 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
proposed patch (1.34 KB, patch)
2010-07-30 17:28 UTC, Andreas J. Guelzow
committed Details | Review

Description Andreas J. Guelzow 2010-07-28 05:16:52 UTC
In Gnumeric when you import a text file with the configurable importer, on the last page of the configuration dialog you can choose formats for each column. The column header indicates the classification of that format: General, Text, Date, Time, Number...

These classifications are obtained by calling
go_format_sel_format_classification (sf));
on the format obtained from the selector.

If you choose an accounting or currency format, the classification says "Number". That is greatly confusing.
Comment 1 Andreas J. Guelzow 2010-07-28 06:08:11 UTC
When we pass the format tot he selector, it figures out the category correctly (using study_format), when we just ask for the family it determines the family by calling  go_format_get_family which seems to return the wrong value.
Comment 2 Morten Welinder 2010-07-29 14:00:53 UTC
go_format_get_family does not know about the meaning of textual annotations
like currency names, units, etc.  And it shouldn't.

Using go_format_get_details might help.
Comment 3 Andreas J. Guelzow 2010-07-30 17:28:57 UTC
Created attachment 166846 [details] [review]
proposed patch

This patch moves the code from study_format (which is used by the selector to determine the family page to open) into study_this_format. Study_this_format is then called both from the original study_format (with the items from the selector) and from go_format_sel_format_classification.
Comment 4 Andreas J. Guelzow 2010-07-30 17:40:32 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.