After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 625361 - Ranges from formulas are sticky and sometimes not shown
Ranges from formulas are sticky and sometimes not shown
Status: RESOLVED FIXED
Product: Gnumeric
Classification: Applications
Component: GUI
git master
Other All
: Normal blocker
: ---
Assigned To: Jody Goldberg
Jody Goldberg
Depends on:
Blocks:
 
 
Reported: 2010-07-27 00:00 UTC by Morten Welinder
Modified: 2010-07-27 20:45 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
proposed patch (7.63 KB, patch)
2010-07-27 07:17 UTC, Jean Bréfort
needs-work Details | Review

Description Morten Welinder 2010-07-27 00:00:37 UTC
1. A1=B1/C1
2. Go to A1.
Note: C1 highlighted in blue.  B1 not highlighted.

3. Press [down]
Bug: C1 still highlighted.

4. Press [up], [f2], [escape]
Bug: nothing highlighted.


"Blocker" because I don't think we want a new release until we
fix this.
Comment 1 Jean Bréfort 2010-07-27 06:52:19 UTC
In 1.8, C1 is highlighted in red only when it is edited, B1 is never highlighted.
What is the correct behavior?
Comment 2 Jean Bréfort 2010-07-27 07:17:29 UTC
Created attachment 166620 [details] [review]
proposed patch

I'm not sure about that, may be not all calls should go inside the if bloc. Actually, only the first one already fixes the issue.
Comment 3 Morten Welinder 2010-07-27 17:38:59 UTC
Review of attachment 166620 [details] [review]:

Patch appears to contain unrelated changes.
Comment 4 Andreas J. Guelzow 2010-07-27 20:12:02 UTC
Jean, we want to highlight ranges only when the cell is added. It should then show all ranges (in various colours) with the current range in blue.

With regard with your patch (ignoring everything but the last hunk): we really should find out why cb_entry_changed is called when we are just selecting it.
Comment 5 Andreas J. Guelzow 2010-07-27 20:45:10 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.


Fixed in this context means to make it consistent with the behaviour in 1.8:

1. A1=B1/C1
2. Go to A1.
1.8 and fixed git:  no highlighting

3. Press [down]
1.8 and fixed git:  no highlighting

4. Press [up], [f2], [escape]
1.8 and fixed git:  no highlighting

We only get high lighting of _all_ ranges involved when we are in fact editing.