GNOME Bugzilla – Bug 624892
Migrate to GSettings
Last modified: 2012-01-27 14:23:54 UTC
Hi, I would like to work on this module towards migration to GSettings. - Rahul
Which rpm I need to install for "gsettings-schema-convert" ? I could not find this on my Fedora 13 installation ? Please help - Rahul
Hi, Please find initial changes attached here. I have not compiled it yet..I am in process of upgrading packages at my Fedora 13. I will upload changes if anything found out during compilation/working. - Rahul
Created attachment 166597 [details] Contains diff command output for changes done. diff command output for changes. - Rahul
any comments please ..
Cool down. Eventually ChPe will get to it. :)
A few comments on the patch: The patch appears to be missing the schemas file? The schemas file needs to be a .in file, and use @INTLTOOL_XML_NOMERGE_RULE@ to produce the final file. + settings = g_settings_new (); Does that actually work? I think not. Also, should separate the real settings from the state (window size, current char) into separate schemas, and make the state delay-apply and only apply on exit. Underscores in gsettings key names need to be replaced by '-'.
Hi Chpe, I missed uploading schema file. will upload it. done most of changes. but i did not get "Also, should separate the real settings from the state (window size, current char) into separate schemas," As of now values of following elements are stored. chapters_mode last_char font height snap_cols_pow2 width maximized fullscreen If i understand correctly then did you mean to have 2 child schemas with following elements for Schema "state" Maximized fullscreen height width and another child schema "info" chapters_mode last_char font snap_cols_pow2 Please let me know your views.
I'd put last_char into the 'state' schema too. Otherwise looks ok to me.
Created attachment 168447 [details] [review] GSettings port code changes for GSettings port.
Hi, Patch attached here. Chpe, last_char is related to application specific data, that's why I have added it under "state" schema. even struct maintained for window state has only following elements. from gucharmap-settings.c typedef struct { guint timeout_id; int width; int height; guint is_maximised : 1; guint is_fullscreen : 1; } WindowState; Please let me know if patch if ok.
Chpe: ping. Could you take a look to the Rahul patch?
Not a blocker.
Can this ever get a review please?
ping
Yeah, ping. Is gucharmap maintained? ;-)
Created attachment 206241 [details] [review] port to GSettings gucharmap-settings only exists now for the window geometry (until Gtk grows support for this).
Attachment 206241 [details] pushed as 6eee95f - port to GSettings