After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 624263 - regression: graphs totally empty
regression: graphs totally empty
Status: RESOLVED FIXED
Product: Gnumeric
Classification: Applications
Component: Charting
git master
Other Linux
: Normal normal
: ---
Assigned To: Jean Bréfort
Jody Goldberg
Depends on:
Blocks:
 
 
Reported: 2010-07-13 15:34 UTC by Kees Cook
Modified: 2010-07-26 23:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
graph of weight over time (110.50 KB, application/vnd.ms-excel)
2010-07-13 15:35 UTC, Kees Cook 		  Details
graphs in 1.10.1 (174.38 KB, image/png)
2010-07-13 15:36 UTC, Kees Cook 		  Details
graphs in git (103.36 KB, image/png)
2010-07-13 15:36 UTC, Kees Cook 		  Details
Fixes the issue (1.33 KB, patch)
2010-07-13 18:52 UTC, Jean Bréfort 		none Details | Review

Description Kees Cook 2010-07-13 15:34:41 UTC 
With 1.10.1 I could open an Excel document that was crashing version 1.10.7.  With git, the crash was fixed (BZ 623960) but this results in a totally empty set of graphs.

I'm using named ranges so that graphs are dynamically updated from a growing data series (since multiple elements are derived from the same set of data).

I've attached the XLS, and screen shots of before and after...
Comment 1 Kees Cook 2010-07-13 15:35:12 UTC 
Created attachment 165809 [details]
graph of weight over time
Comment 2 Kees Cook 2010-07-13 15:36:34 UTC 
Created attachment 165810 [details]
graphs in 1.10.1
Comment 3 Kees Cook 2010-07-13 15:36:58 UTC 
Created attachment 165811 [details]
graphs in git
Comment 4 Kees Cook 2010-07-13 15:37:59 UTC 
(As a random note, the blue vertical lines in the "before" graph is a separate bug: it does not seem that setting fill-type "None" for that element gets saved to disk.)
Comment 5 Jean Bréfort 2010-07-13 15:57:49 UTC 
Needs some investigation. I don't understand what happens for now.
I do not understand which blue vertical lines are not saved, do you mean the filling of the "#offset" series?
Comment 6 Jean Bréfort 2010-07-13 18:52:56 UTC 
Created attachment 165825 [details] [review]
Fixes the issue

I still need to investigate the style issue.
Comment 7 Jean Bréfort 2010-07-13 19:18:33 UTC 
Both issues are now fixed, but the first chart in the sample leaks two values, and I'm getting criticals such as:
CRITICAL **: go_data_vector_get_str: assertion `(int)i < vec->len' failed
Comment 8 Morten Welinder 2010-07-13 20:06:21 UTC 
If I read that patch right, you're left with two "l" variables, one
shadowing the other.
Comment 9 Jean Bréfort 2010-07-13 20:34:17 UTC 
Oops, forgot to remove the old line. Done.
Comment 10 Jean Bréfort 2010-07-13 21:05:58 UTC 
This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.
The duplicated line was the reason for the values leak.
Comment 11 Kees Cook 2010-07-26 23:04:58 UTC 
Thanks Jean and Morten!