After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 624171 - File Version not updated
File Version not updated
Status: RESOLVED FIXED
Product: Gnumeric
Classification: Applications
Component: General
1.10.x
Other Windows
: Normal minor
: ---
Assigned To: Jody Goldberg
Jody Goldberg
Depends on:
Blocks:
 
 
Reported: 2010-07-12 14:42 UTC by Pedro Lino
Modified: 2010-07-15 00:09 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Pedro Lino 2010-07-12 14:42:41 UTC
As reported on the IRC channel, the File Version and Product Version information fields for the Windows binaries still report version 1.10.6 although the version number in the About box was correctly updated to 1.10.7

This might sound just cosmetic but allows Windows users to check if a new version was released ;)
Comment 1 Andreas J. Guelzow 2010-07-12 15:12:15 UTC
Pedro, do you know where that 1.10.6 comes from? In the build files for the Windows binaries, I see:

; HM NIS Edit Wizard helper defines
!define GNM_NAME		"Gnumeric"
!define GNM_LONGNAME		"Gnumeric Spreadsheet"
!define GNM_APPNAME		"Gnumeric Spreadsheet"
!define GNM_VERSION		"@VERSION@"
!define GNM_VERSION_TAG		"@YYYYMMDD@"
!define GNM_VERSION_FULL	"${GNM_VERSION}-${GNM_VERSION_TAG}"

...

OutFile			"gnumeric-${GNM_VERSION_FULL}.exe"

...

!define GNM_ROOT	"$INSTDIR\${GNM_VERSION}"

...

    WriteRegStr SHCTX "Software\GNOME\${GNM_NAME}" "Path" "${GNM_ROOT}\bin"
    WriteRegStr SHCTX "Software\GNOME\${GNM_NAME}" "Version" "${GNM_VERSION_FULL}"

So all of this version info should match. In which directory is your gnumeric installed?
Comment 2 Pedro Lino 2010-07-12 16:30:59 UTC
All this information matches. It is installed in C:\Program Files\Gnumeric\1.10.7\bin as expected

You should look for some line containing "File Version" or "Product Version" or "The Gnumeric Team"
Comment 3 Andreas J. Guelzow 2010-07-12 16:44:42 UTC
So that should have to do with thh file src/gnumeric.rc:
-----------------------------------------------------------
#define xstr(s) str(s)
#define str(s) #s

#include <winver.h>

500 ICON MOVEABLE PURE LOADONCALL DISCARDABLE "../icons/win32-gnumeric.ico"

VS_VERSION_INFO VERSIONINFO
  FILEVERSION VERSION_NUMBER
  PRODUCTVERSION VERSION_NUMBER
  FILEFLAGSMASK 0
  FILEFLAGS 0
  FILEOS VOS__WINDOWS32
  FILETYPE VFT_DLL
  FILESUBTYPE VFT2_UNKNOWN
  BEGIN
    BLOCK "StringFileInfo"
    BEGIN
      BLOCK "040904B0"
      BEGIN
	VALUE "CompanyName", "The Gnumeric Team"
	VALUE "FileDescription", "Gnumeric"
	VALUE "FileVersion", xstr(VERSION)
	VALUE "LegalCopyright", "Copyright 2010 by The Gnumeric Team and others"
	VALUE "ProductName", "Gnumeric"
	VALUE "ProductVersion", xstr(VERSION)
      END
    END
    BLOCK "VarFileInfo"
    BEGIN
      VALUE "Translation", 0x409, 1200
    END
  END
-----------------------------------------------------------
Comment 4 Morten Welinder 2010-07-12 17:23:32 UTC
That sounds like something that needs to be forced recompiled.
Comment 5 Morten Welinder 2010-07-15 00:09:33 UTC
This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.