After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 623585 - jpegdec: fails to skip extra 0xff markers at start
jpegdec: fails to skip extra 0xff markers at start
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal blocker
: 0.10.24
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on: 622690
Blocks:
 
 
Reported: 2010-07-05 10:07 UTC by Mark Nauwelaerts
Modified: 2010-07-05 11:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
jpegdec: fix skipping extra 0xff markers (at start) (903 bytes, patch)
2010-07-05 10:07 UTC, Mark Nauwelaerts 		accepted-commit_now Details | Review

Description Mark Nauwelaerts 2010-07-05 10:07:23 UTC 
Created attachment 165264 [details] [review]
jpegdec: fix skipping extra 0xff markers (at start)

+++ This bug was initially created as a clone of Bug #622690 +++

Created an attachment (id=164588)
GST_DEBUG=2,jpeg*:5 make elements/jpegparse.check > log 2>&1

jpeg 8b

gstcheck.c:472:F:jpegparse:test_parse_single_byte:0: We expected 4 buffers, but there are 3 buffers
gstcheck.c:472:F:jpegparse:test_parse_all_in_one_buf:0: We expected 4 buffers, but there are 3 buffers

----

It turns out the same 'misprint' is in jpegdec.  Short patch attached.
Comment 1 Tim-Philipp Müller 2010-07-05 10:41:30 UTC 
Comment on attachment 165264 [details] [review]
jpegdec: fix skipping extra 0xff markers (at start)

I'm sure it used to do that at some point..
Comment 2 Mark Nauwelaerts 2010-07-05 11:42:44 UTC 
It used to indeed, but that got glitched when re-written to adapter scanning :(

commit 6f84bbe34e95bedb58a53f8ec5b56a1f15304485
Author: Mark Nauwelaerts <mark.nauwelaerts@collabora.co.uk>
Date:   Mon Jul 5 12:05:57 2010 +0200

    jpegdec: fix skipping extra 0xff markers
    
    Fixes #623585.