After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 622246 - Add key highlighting
Add key highlighting
Status: RESOLVED FIXED
Product: caribou
Classification: Applications
Component: default
git master
Other Linux
: Normal enhancement
: ---
Assigned To: caribou-maint
caribou-maint
Depends on:
Blocks:
 
 
Reported: 2010-06-20 22:44 UTC by Daniel Baeyens
Modified: 2010-09-01 18:22 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Added schema entry for key colors (1.47 KB, patch)
2010-06-20 22:45 UTC, Daniel Baeyens
none Details | Review
UI changed on the preferences window for key color configuration (21.39 KB, patch)
2010-06-20 22:46 UTC, Daniel Baeyens
none Details | Review
Implementation for key color configuration (4.24 KB, patch)
2010-06-20 22:46 UTC, Daniel Baeyens
none Details | Review
Fixed line width. Added default values for gconf settings (3.68 KB, patch)
2010-06-27 20:33 UTC, Daniel Baeyens
none Details | Review
Proper highlight colors. (13.25 KB, patch)
2010-08-16 16:58 UTC, Eitan Isaacson
committed Details | Review

Description Daniel Baeyens 2010-06-20 22:44:58 UTC
Some people can be interested on change the base color of the keyboard or even remark the key colors when the mouse is over them

Implementation of a system to change these two colors and store the changes is needed
Comment 1 Daniel Baeyens 2010-06-20 22:45:39 UTC
Created attachment 164180 [details] [review]
Added schema entry for key colors
Comment 2 Daniel Baeyens 2010-06-20 22:46:12 UTC
Created attachment 164181 [details] [review]
UI changed on the preferences window for key color configuration
Comment 3 Daniel Baeyens 2010-06-20 22:46:36 UTC
Created attachment 164182 [details] [review]
Implementation for key color configuration
Comment 4 Eitan Isaacson 2010-06-21 16:39:38 UTC
I am concerned that we might be adding too many options to the UI. I agree that there needs to be an option to override the color, but I am not sure if it should be in the UI.

I am applying these to trunk anyway, but we will need to redesign the preferences UI in the future, IMHO.
Comment 5 Eitan Isaacson 2010-06-21 16:41:31 UTC
Oops! It's only for mouse-over, I get it. Anyway, we need to think about how to keep the amount of preferences we will have in a sane UI. But that is another task..
Comment 6 Eitan Isaacson 2010-06-21 17:23:37 UTC
Review of attachment 164182 [details] [review]:

Please break lines that are longer than 80 characters.

::: caribou/ui/keyboard.py
@@ +62,3 @@
         layout_combo.connect("changed", self._on_layout_changed, client)
+        normal_color = gtk.gdk.Color(client.get_string(const.CARIBOU_GCONF + "/normal_color"))
+        normal_state_color_button = builder.get_object("normal_state_color_button")

There should be a fallback here when no gconf key is set and no schema is installed.

@@ +67,3 @@
+        normal_state_color_button.set_color(normal_color)
+        normal_color = gtk.gdk.Color(client.get_string(const.CARIBOU_GCONF + "/normal_color"))
+        normal_state_color_button = builder.get_object("normal_state_color_button")

ditto

@@ +337,3 @@
+
+        self._update_colors()
+    def _colors_changed(self, client, connection_id, entry, args):

ditto
Comment 7 Daniel Baeyens 2010-06-27 20:33:49 UTC
Created attachment 164767 [details] [review]
Fixed line width. Added default values for gconf settings
Comment 8 Eitan Isaacson 2010-07-12 18:02:35 UTC
Merged in master.

I think there should be a checkbox that makes these settings insensitive and make default/highlight conform with the GTK+ theme.
Comment 9 Eitan Isaacson 2010-08-16 16:58:46 UTC
Created attachment 167976 [details] [review]
Proper highlight colors.
Comment 10 Eitan Isaacson 2010-08-16 16:59:26 UTC
The patch above adds a checkbox for using the default color theme.
Comment 11 Eitan Isaacson 2010-09-01 18:22:18 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.