After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 621773 - Add introspection annotations
Add introspection annotations
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
unspecified
Other All
: Normal normal
: 0.10.30
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on: 621716
Blocks:
 
 
Reported: 2010-06-16 12:34 UTC by Johan (not receiving bugmail) Dahlin
Modified: 2010-06-16 17:05 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add a couple of annotations (1.61 KB, patch)
2010-06-16 12:34 UTC, Johan (not receiving bugmail) Dahlin
none Details | Review
[gstminiobject] Add annotations for introspection (957 bytes, patch)
2010-06-16 12:34 UTC, Johan (not receiving bugmail) Dahlin
none Details | Review
[gstminiobject] Add annotations for introspection (28.41 KB, patch)
2010-06-16 14:08 UTC, Johan (not receiving bugmail) Dahlin
none Details | Review
[gstmessage] Add out annotations (13.69 KB, patch)
2010-06-16 16:11 UTC, Johan (not receiving bugmail) Dahlin
committed Details | Review
[gstquery] Add out annotations (7.54 KB, patch)
2010-06-16 16:11 UTC, Johan (not receiving bugmail) Dahlin
committed Details | Review
[gstevent] Add out annotations (6.50 KB, patch)
2010-06-16 16:11 UTC, Johan (not receiving bugmail) Dahlin
committed Details | Review
[miniobject] Add introspection annotations (904 bytes, patch)
2010-06-16 16:11 UTC, Johan (not receiving bugmail) Dahlin
committed Details | Review
[gstelementfactory] Add an allow-none annotation (1.09 KB, patch)
2010-06-16 16:11 UTC, Johan (not receiving bugmail) Dahlin
committed Details | Review

Description Johan (not receiving bugmail) Dahlin 2010-06-16 12:34:17 UTC
Add a couple of annotations required to use GstMiniObject
in an introspected based binding such as gjs
Comment 1 Johan (not receiving bugmail) Dahlin 2010-06-16 12:34:20 UTC
Created attachment 163810 [details] [review]
Add a couple of annotations

Add annotations for gst_element_factory_make and
gst_message_parse_state_changed.
Comment 2 Johan (not receiving bugmail) Dahlin 2010-06-16 12:34:25 UTC
Created attachment 163811 [details] [review]
[gstminiobject] Add annotations for introspection

GstMiniObject requires a couple of annotations so introspection
can know how to ref/unref and convert to/from a GValue.
Comment 3 Johan (not receiving bugmail) Dahlin 2010-06-16 12:36:25 UTC
Everything except the gst_element_factory_make annotation depends on bug 568913 and bug 621716
Comment 4 Johan (not receiving bugmail) Dahlin 2010-06-16 14:08:37 UTC
Created attachment 163828 [details] [review]
[gstminiobject] Add annotations for introspection

GstMiniObject requires a couple of annotations so introspection
can know how to ref/unref and convert to/from a GValue.

This should mark all out arguments for *_parse_* functions
in GstEvent GstMessage and GstQuery. It also marks the second
parameter of gst_element_factory_make as allow-none
Comment 5 Sebastian Dröge (slomo) 2010-06-16 15:50:37 UTC
Best would be if you could split the changes a bit, one patch per source file or something :)
Comment 6 Johan (not receiving bugmail) Dahlin 2010-06-16 16:11:31 UTC
Created attachment 163840 [details] [review]
[gstmessage] Add out annotations
Comment 7 Johan (not receiving bugmail) Dahlin 2010-06-16 16:11:42 UTC
Created attachment 163841 [details] [review]
[gstquery] Add out annotations
Comment 8 Johan (not receiving bugmail) Dahlin 2010-06-16 16:11:48 UTC
Created attachment 163842 [details] [review]
[gstevent] Add out annotations
Comment 9 Johan (not receiving bugmail) Dahlin 2010-06-16 16:11:54 UTC
Created attachment 163843 [details] [review]
[miniobject] Add introspection annotations

These are required to know how to unref/ref and
convert to/from a GValue.
Comment 10 Johan (not receiving bugmail) Dahlin 2010-06-16 16:11:59 UTC
Created attachment 163844 [details] [review]
[gstelementfactory] Add an allow-none annotation