After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 620939 - [oggdemux] No support for Skeleton 4.0 streams
[oggdemux] No support for Skeleton 4.0 streams
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal blocker
: 0.10.30
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-06-08 09:17 UTC by Sebastian Dröge (slomo)
Modified: 2010-08-30 15:40 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Sebastian Dröge (slomo) 2010-06-08 09:17:40 UTC
File in question is: http://pearce.org.nz/video/big_buck_bunny_427x240.indexed.ogg


In pull mode oggdemux gets the duration, in push mode it doesn't. Without a duration seeking is impossible
Comment 1 Sebastian Dröge (slomo) 2010-06-08 09:27:18 UTC
Also parsing of the index and everything seems to be broken...
Comment 2 Sebastian Dröge (slomo) 2010-06-08 11:16:18 UTC
This fixes it but there's a inconsistency between existing files and the spec unfortunately (see the FIXME in the code). We should fix this before 0.10.30 after getting an answer from the Ogg guys :)

commit 3f3691085a49e130c459bccc475707d1951d6244
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Tue Jun 8 13:11:05 2010 +0200

    oggdemux: Implement correct parsing of Skeleton 4.0 index packets

commit cba98e05cfb1a2045b5c7401c8f51f9fdf704425
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Tue Jun 8 12:01:15 2010 +0200

    oggdemux: Add parsing of Skeleton 4.0 indexes
Comment 3 Sebastian Dröge (slomo) 2010-06-08 11:18:01 UTC
Also the total time is now updated from the index page handling but this doesn't post a duration message or something on the bus.
Comment 4 Sebastian Dröge (slomo) 2010-06-09 14:39:26 UTC
commit bb7773b40a7b7bf496d489e0d6bb662626228b11
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Wed Jun 9 16:38:34 2010 +0200

    oggdemux: Update the total time from the Skeleton 4 indexes
    
    Fixes bug #620939, see bug #607945.

commit 7bade30f5ef8b9763094b0fee8d65dab388ef2c9
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Wed Jun 9 16:33:25 2010 +0200

    oggstream: Implement latest version of the Skeleton 4.0 spec
    
    Fixes bug #620939.
Comment 5 madbiologist 2010-08-28 12:51:04 UTC
Does this fix application/ogv as well as application/ogg?  Or does it only fix application/ogg?

See https://bugs.launchpad.net/ubuntu/+source/gstreamer0.10/+bug/624722
Comment 6 Sebastian Dröge (slomo) 2010-08-28 13:10:41 UTC
application/ogg and application/ogv are the same for GStreamer. But yes, this is going to fix the Ubuntu bug. The fix will be in gst-plugins-base 0.10.31