After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 620719 - Change of labels range spoils data range in line plot
Change of labels range spoils data range in line plot
Status: RESOLVED FIXED
Product: Gnumeric
Classification: Applications
Component: Charting
git master
Other Linux
: Normal normal
: ---
Assigned To: Jean Bréfort
Jody Goldberg
Depends on:
Blocks:
 
 
Reported: 2010-06-06 06:39 UTC by Konstantin Tokarev
Modified: 2010-06-08 18:19 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Test file for bug (2.49 KB, application/octet-stream)
2010-06-06 07:40 UTC, Konstantin Tokarev 		  Details
proposed patch (697 bytes, patch)
2010-06-08 10:20 UTC, Jean Bréfort 		committed Details | Review

Description Konstantin Tokarev 2010-06-06 06:39:22 UTC 
To reproduce:
1. Create any line plot
2. Go to settings of data series, change labels range using keyboard
3. Click into another text field - see data range is replaced with new label range too (clicking "apply" has the same effect)
Comment 1 Jean Bréfort 2010-06-06 07:02:17 UTC 
I'm unable to replicate, can you provide a sample file and precise instructions o how to reproduce?
Comment 2 Konstantin Tokarev 2010-06-06 07:40:15 UTC 
Created attachment 162851 [details]
Test file for bug

1. Open dialog with settings of chart
2. Goto PlotLine1->Series1
3. Change labels range from $A$1:$A$5 to $C$1:$C$5
3. Click on field with range of values - see it changed from $B$1:$B$5 to $C$1:$C$5
Comment 3 Jean Bréfort 2010-06-06 07:56:34 UTC 
I can't reproduce. Which gtk+ version are you using? May be something changed there (once more).
Comment 4 Andreas J. Guelzow 2010-06-06 15:22:58 UTC 
I can't reproduce either.
Comment 5 Andreas J. Guelzow 2010-06-07 20:01:10 UTC 
Konstantin, which gtk+ version are you using?
Comment 6 Konstantin Tokarev 2010-06-08 06:23:12 UTC 
Sorry for late reply,
I can reproduce bug on three systems:
Debian 5.0 + Gtk from lenny-backports (libgtk-2.0 2.18.6)
Fluxbuntu (libgtk-2.0 2.20.0)
another Fluxbuntu (will report libgtk version later if needed)
Comment 7 Jean Bréfort 2010-06-08 06:33:51 UTC 
I'm using 2.20.1 and can't reproduce. How do you change the labels? using the keyboard, or by selecting with the mouse?
Comment 8 Konstantin Tokarev 2010-06-08 06:36:41 UTC 
keyboard
Comment 9 Jean Bréfort 2010-06-08 06:40:52 UTC 
Ah, I could just reproduce.
Comment 10 Jean Bréfort 2010-06-08 06:44:41 UTC 
Thgis only happens if I type C1:C5, not when I type $C1:$C5. Quite strange.
Comment 11 Konstantin Tokarev 2010-06-08 06:51:40 UTC 
I found it when changed letters (in this case 'a' to 'c') without touching $$.
Comment 12 Jean Bréfort 2010-06-08 07:54:38 UTC 
OK, seen that too. If you type 'C' things work. What seems to happen is that gnumeric canonicalize the entry if needed, but puts the result in the active entry, not where it should go.
Comment 13 Jean Bréfort 2010-06-08 10:20:07 UTC 
Created attachment 163038 [details] [review]
proposed patch

This a more general issue. When the string needs updating, the active entry is updated even if it is not the right one. Not sure the patch would not break anything else. Needs review.
Comment 14 Andreas J. Guelzow 2010-06-08 17:52:00 UTC 
Comment on attachment 163038 [details] [review]
proposed patch

This looks good. The  gnumeric-expr-entry should only ever affect its own entry and the sheet while it is active. So if this patch would break something else then it was already broken!
Comment 15 Jean Bréfort 2010-06-08 18:19:24 UTC 
This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.