After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 619273 - [matroskamux] reduce downstream spam
[matroskamux] reduce downstream spam
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal enhancement
: 0.10.24
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-05-21 09:33 UTC by Mark Nauwelaerts
Modified: 2010-06-01 14:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix ebml write caching using bytewriter (7.18 KB, patch)
2010-05-21 09:33 UTC, Mark Nauwelaerts 		committed Details | Review
Use write caching also when writing buffers (5.92 KB, patch)
2010-05-21 09:34 UTC, Mark Nauwelaerts 		committed Details | Review
Adjust matroskamux unit test to new behaviour (6.13 KB, patch)
2010-05-21 09:34 UTC, Mark Nauwelaerts 		committed Details | Review

Description Mark Nauwelaerts 2010-05-21 09:33:16 UTC 
Created attachment 161621 [details] [review]
Fix ebml write caching using bytewriter

Some patches follow that should reduce the various small buffers and seeks that matroskamux inflicts on downstream.
Comment 1 Mark Nauwelaerts 2010-05-21 09:34:00 UTC 
Created attachment 161622 [details] [review]
Use write caching also when writing buffers
Comment 2 Mark Nauwelaerts 2010-05-21 09:34:36 UTC 
Created attachment 161623 [details] [review]
Adjust matroskamux unit test to new behaviour
Comment 3 Zaheer Abbas Merali 2010-06-01 10:57:18 UTC 
works well, thanks for the patch!
Comment 4 Mark Nauwelaerts 2010-06-01 14:06:45 UTC 
commit b8fd1a91f1ef90893549788074ada06c66ac13ab
Author: Mark Nauwelaerts <mark.nauwelaerts@collabora.co.uk>
Date:   Thu May 20 14:33:41 2010 +0200

    matroskamux: use write caching also when writing buffer data
    
    Specifically, this reduces pushing several small buffers for each
    data buffer and also avoids a seek for each buffer altogether
    (though a seek is still needed for each cluster).
    
    Fixes #619273.

commit 81bf657aa70646531dc50a379fa8cdee2bc126ee
Author: Mark Nauwelaerts <mark.nauwelaerts@collabora.co.uk>
Date:   Thu May 20 14:23:07 2010 +0200

    matroskamux: fix ebml write caching with bytewriter implementation
    
    Also cache a bit more during header writing.
    
    Fixes #619273.

Author: Mark Nauwelaerts <mark.nauwelaerts@collabora.co.uk>
Date:   Fri May 21 11:21:58 2010 +0200

    matroskamux: adjust unit test to modified behaviour