After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 619064 - h264parse: broken timestamps after seeking
h264parse: broken timestamps after seeking
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other All
: Normal normal
: 0.10.19
Assigned To: GStreamer Maintainers
GStreamer Maintainers
: 619294 621973 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2010-05-19 08:56 UTC by Alessandro Decina
Modified: 2010-06-29 12:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fix (972 bytes, patch)
2010-05-19 08:56 UTC, Alessandro Decina 		committed Details | Review

Description Alessandro Decina 2010-05-19 08:56:08 UTC 
Created attachment 161414 [details] [review]
fix

In some cases h264parse produces wrong timestamps after seeks.

It's due to this check in gsth264parse.c, around line 1182:

      if (h264parse->last_outbuf_dts != GST_CLOCK_TIME_NONE
          && outbuf_dts != GST_CLOCK_TIME_NONE
          && outbuf_dts <= h264parse->last_outbuf_dts)
        outbuf_dts = GST_CLOCK_TIME_NONE;

h264parse->last_outbuf_dts is set to GST_CLOCK_TIME_NONE in _init and it's not being reset during a flush.
Comment 1 Tim-Philipp Müller 2010-05-19 09:08:40 UTC 
Comment on attachment 161414 [details] [review]
fix

(PS: I think the description and summary line in the commit message should be swapped)
Comment 2 Alessandro Decina 2010-05-19 09:19:43 UTC 
commit 2441c79afa426848f2896434249dd38646cceff7
Author: Alessandro Decina <alessandro.d@gmail.com>
Date:   Tue May 18 21:32:22 2010 +0200

    h264parse: fix wrong timestamps in some cases after seeking.
    
    Reset ->last_outbuf_dts on flush-stop. Fixes #619064.
Comment 3 Levente Farkas 2010-05-24 12:06:57 UTC 
can you tell me which release will include thus fix?
thanks in advance.
Comment 4 Tim-Philipp Müller 2010-05-24 12:22:09 UTC 
The next release, obviously, which is 0.10.19.
Comment 5 Levente Farkas 2010-05-24 13:10:24 UTC 
just because according to http://gstreamer.freedesktop.org/wiki/ReleasePlanning2010
bad is frozen since may 7. or is it outdated? i'd like to be see this fix in 10.19:-)
Comment 6 Tim-Philipp Müller 2010-06-29 09:01:09 UTC 
*** Bug 619294 has been marked as a duplicate of this bug. ***
Comment 7 Tim-Philipp Müller 2010-06-29 12:13:10 UTC 
*** Bug 621973 has been marked as a duplicate of this bug. ***