After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 618940 - rtptheorapay/depay wrongly claims to do delivery-method=inline
rtptheorapay/depay wrongly claims to do delivery-method=inline
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal blocker
: 0.10.23
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-05-17 22:51 UTC by Olivier Crête
Modified: 2010-06-03 22:48 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch to fix the static caps in rtptheorapay/depay (2.22 KB, patch)
2010-05-17 22:52 UTC, Olivier Crête
none Details | Review
improved caps (4.54 KB, patch)
2010-05-25 15:15 UTC, Wim Taymans
none Details | Review
Let the payloader announce the delivery-method it uses for backwards compatibiliyt (1.07 KB, patch)
2010-05-31 15:29 UTC, Sjoerd Simons
committed Details | Review

Description Olivier Crête 2010-05-17 22:51:56 UTC
The payloader's static caps do not include a "configuration" parameter, so having the delivery method as inline is a lie. The depayloader can also support in-band, so it was also a lie there.
Comment 1 Olivier Crête 2010-05-17 22:52:42 UTC
Created attachment 161290 [details] [review]
patch to fix the static caps in rtptheorapay/depay
Comment 2 Mark Nauwelaerts 2010-05-18 08:47:28 UTC
It seems the above patch also includes a change to common/ (which is probably not intended).

Also, the payloader code will still effectively produce src caps that do have delivery-method=inline, so the template src caps are not so much a lie in that case (and present RFC still seems to have delivery-method required ...)?
Comment 3 Olivier Crête 2010-05-18 15:34:06 UTC
Arg, I hate common/

The payloader will also send the caps in-band, so delivery-method should be "inline & inband".. Anyway, looking at the delivery method is a bit a waste of time if you ask me.
Comment 4 Tim-Philipp Müller 2010-05-21 19:35:36 UTC
What's the conclusion on this?
Comment 5 Wim Taymans 2010-05-25 15:15:45 UTC
Created attachment 161949 [details] [review]
improved caps

Improved patch that also avoids setting the property on the srcpad and parsing the property.
Comment 6 Wim Taymans 2010-05-25 16:54:42 UTC
commit 49463a37cbaa952e1401291f0a2623de6cab3880
Author: Wim Taymans <wim.taymans@collabora.co.uk>
Date:   Tue May 25 17:05:12 2010 +0200

    rtptheora: remove delivery-method from caps
    
    We can accept all delivery methods so don't advertise anything on the caps or
    parse anything, we will handle whatever we receive.
    
    Fixes #618940
Comment 7 Sjoerd Simons 2010-05-31 12:48:59 UTC
This breaks compatibility with people running old versions of farsight2/gstreamer for Theora as a codec for VOIP.. While we might not care about how receive the configurations stuff, we should still announce it for compatibility reasons..
Comment 8 Sjoerd Simons 2010-05-31 15:29:30 UTC
Created attachment 162387 [details] [review]
Let the payloader announce the delivery-method it uses for backwards compatibiliyt
Comment 9 Olivier Crête 2010-05-31 15:40:52 UTC
Comment on attachment 162387 [details] [review]
Let the payloader announce the delivery-method it uses for backwards compatibiliyt

looks good to me
Comment 10 Olivier Crête 2010-06-03 22:48:37 UTC
Comment on attachment 162387 [details] [review]
Let the payloader announce the delivery-method it uses for backwards compatibiliyt

commit 952fd666b3278c2780777e14f8523a7c5fafee2f
Author: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Date:   Mon May 31 16:26:19 2010 +0100

    Keep announcing the delivery-method in the capabilities
    
    Even though we don't use delivery-method in our payloader, older versions of
    the theora payloader in gstreamer required it. As such we need to keep this
    around in the caps for backwards-compatibility.
    
    This reverts part of 49463a37cbaa952e1401291f0a2623de6cab3880
    
    Fixes #618940