After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 618527 - festival plugin does not close connections to server
festival plugin does not close connections to server
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 0.10.19
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-05-13 11:08 UTC by ivan
Modified: 2010-05-13 12:43 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch to gstfestival.c (1.18 KB, patch)
2010-05-13 11:08 UTC, ivan 		committed Details | Review

Description ivan 2010-05-13 11:08:18 UTC 
Created attachment 160966 [details] [review]
patch to gstfestival.c

Current version of the festival plugin does not close connections to festival server, rather it opens new connection with each element status change, so festival server soon stops responding because it'll have too many connected clients.
The problem was that plugin uses flag to see if connection should be open, but this flag was not setup after opening the connection.
Attached patch fixed it for me.

Regards
Ivan
Comment 1 Sebastian Dröge (slomo) 2010-05-13 12:43:48 UTC 
commit f09a8893c12e3cc9af59751c7e3e199abc81126c
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Thu May 13 14:42:48 2010 +0200

    festival: Only close the connection if it's opened

commit 41bba48ccbadeea109db53fe265481254afbf3de
Author: Ivan Zderadicka <ivan.zderadicka@gmail.com>
Date:   Thu May 13 14:41:08 2010 +0200

    festival: Don't open an infinite number of connections to the server and close connecti
    
    Fixes bug #618527.