After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 618351 - avimux crashes when fed from filesrc
avimux crashes when fed from filesrc
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal critical
: 0.10.23
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-05-11 09:36 UTC by Benjamin Otte (Company)
Modified: 2010-05-11 12:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Check that pads have been negotiated (1.49 KB, patch)
2010-05-11 10:07 UTC, Mark Nauwelaerts 		committed Details | Review

Description Benjamin Otte (Company) 2010-05-11 09:36:48 UTC 
Running the following pipeline
  gst-launch filesrc location=/bin/bash ! avimux ! fakesink
causes a SIGFPE in avimux.

While this pipeline is wrong and should not work, it should not crash either. In particular, it's a common pipeline for newcomers to encounter when they start experimenting with GStreamer.

Not sure what the right fix is (check that all pads are negotiated probably?), so I'm filing this.
Comment 1 Benjamin Otte (Company) 2010-05-11 09:37:22 UTC 
Also, https://bugzilla.redhat.com/show_bug.cgi?id=590699 is the upstream bug report.
Comment 2 Sebastian Dröge (slomo) 2010-05-11 09:45:40 UTC 
Yes, you should check in the collected function, that all pads are properly negotiated. And probably add some checks in the setcaps functions too.
Comment 3 Mark Nauwelaerts 2010-05-11 10:07:00 UTC 
Created attachment 160807 [details] [review]
Check that pads have been negotiated
Comment 4 Sebastian Dröge (slomo) 2010-05-11 11:52:58 UTC 
I guess this should go in before gst-plugins-good freezes for the next release.
Comment 5 Mark Nauwelaerts 2010-05-11 11:59:55 UTC 
commit 5ae7119d11ba959c23cdaf57ebf61aeb06b77253
Author: Mark Nauwelaerts <mark.nauwelaerts@collabora.co.uk>
Date:   Tue May 11 12:06:10 2010 +0200

    avimux: check that pads have been negotiated

    Also set fcc_handler field in audio stream header.

    Fixes #618351.