After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 618305 - [flvmux] last timestamp is stored even if it's invalid
[flvmux] last timestamp is stored even if it's invalid
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 0.10.23
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-05-10 20:18 UTC by Jan Urbański
Modified: 2010-05-11 04:36 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch to fix the issue (789 bytes, patch)
2010-05-10 20:20 UTC, Jan Urbański
committed Details | Review

Description Jan Urbański 2010-05-10 20:18:53 UTC
For example:

$ gst-launch audiotestsrc num-buffers=10 ! speexenc ! flvmux ! filesink location=/tmp/foo.flv

$ debug-flv /tmp/foo.flv
(...)
#00002 <AudioTag at offset 0x000009F1, time 0, size 81, Speex>
#00003 <AudioTag at offset 0x00000A51, time 2007021037, size 71, Speex>
#00004 <AudioTag at offset 0x00000AA7, time 2007021037, size 75, Speex>
(...)

the third and fourth FLV tag have a ridiculous timestamp. That's because flvmux saves the timestamp of the last buffer pushed and uses it if the incoming buffer has an invalid timestamp and it does it regardless of whether that timestamp to be saved is valid or not.

The solution is to only store the last timestamp if it's valid.
Comment 1 Jan Urbański 2010-05-10 20:20:02 UTC
Created attachment 160761 [details] [review]
patch to fix the issue
Comment 2 Sebastian Dröge (slomo) 2010-05-11 04:36:38 UTC
commit cf57f1b220ccaf591649db11faaf61359ac28b0c
Author: Jan Urbański <wulczer@wulczer.org>
Date:   Mon May 10 22:11:10 2010 +0200

    flvmux: only store the last buffer timestamp if it's valid
    
    Fixes bug #618305