GNOME Bugzilla – Bug 617078
Wrong include paths in amr elements
Last modified: 2010-04-28 13:25:10 UTC
Amr elements include openamr headers like this: #include <opencore-amrnb/dec_if.h> However, this is incorrect, because opencore-amrnb has this in its .pc file: includedir=${prefix}/include/opencore-amrnb So, the correct way to include dec_if.h is: #include <def_if.h> configure.ac does have PKG_CHECK_MODULES(AMRNB, ...) and ext/amrnb/Makefile.am does have AMRNB_CFLAGS put into CFLAGS, so there's no reason to continue to rely on opencore-amrnb directory being in include path (although configure.ac also has a fallback in case PKG_CHECK_MODULES() fails, and that fallback doesn't look too good, as it would only work with opencore-amrnb in include path)
Created attachment 159793 [details] [review] Use correct include paths (as pkg-config include path suggests)
Indeed, thanks for the patch: commit ba089d504bff729760982bd59f3a8d10a8aa39be Author: Руслан Ижбулатов <lrn1986@gmail.com> Date: Wed Apr 28 17:10:36 2010 +0400 amr: Use correct includes (as pkg-config suggests) Fixes #617078