After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 617078 - Wrong include paths in amr elements
Wrong include paths in amr elements
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-ugly
git master
Other All
: Normal trivial
: 0.10.15
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-04-28 13:11 UTC by LRN
Modified: 2010-04-28 13:25 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Use correct include paths (as pkg-config include path suggests) (1.46 KB, patch)
2010-04-28 13:12 UTC, LRN
committed Details | Review

Description LRN 2010-04-28 13:11:47 UTC
Amr elements include openamr headers like this:
#include <opencore-amrnb/dec_if.h>
However, this is incorrect, because opencore-amrnb has this in its .pc file:
includedir=${prefix}/include/opencore-amrnb
So, the correct way to include dec_if.h is:
#include <def_if.h>
configure.ac does have PKG_CHECK_MODULES(AMRNB, ...) and ext/amrnb/Makefile.am does have AMRNB_CFLAGS put into CFLAGS, so there's no reason to continue to rely on opencore-amrnb directory being in include path (although configure.ac also has a fallback in case PKG_CHECK_MODULES() fails, and that fallback doesn't look too good, as it would only work with opencore-amrnb in include path)
Comment 1 LRN 2010-04-28 13:12:33 UTC
Created attachment 159793 [details] [review]
Use correct include paths (as pkg-config include path suggests)
Comment 2 Tim-Philipp Müller 2010-04-28 13:24:32 UTC
Indeed, thanks for the patch:

commit ba089d504bff729760982bd59f3a8d10a8aa39be
Author: Руслан Ижбулатов <lrn1986@gmail.com>
Date:   Wed Apr 28 17:10:36 2010 +0400

    amr: Use correct includes (as pkg-config suggests)
    
    Fixes #617078