After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 616860 - GnomeGoal: Correct Sound-Juicer desktop files
GnomeGoal: Correct Sound-Juicer desktop files
Status: RESOLVED FIXED
Product: sound-juicer
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Sound Juicer Maintainers
Sound Juicer Maintainers
Depends on:
Blocks: 588975
 
 
Reported: 2010-04-26 15:23 UTC by Martin Blanchard
Modified: 2011-09-10 15:24 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
GnomeGoal : CorrectDesktopFile (541 bytes, patch)
2010-04-26 15:23 UTC, Martin Blanchard 		none Details | Review
updated desktop file patch (424 bytes, patch)
2011-08-06 07:28 UTC, Alexandre Rostovtsev 		committed Details | Review

Description Martin Blanchard 2010-04-26 15:23:41 UTC 
Created attachment 159616 [details] [review]
GnomeGoal : CorrectDesktopFile

See http://live.gnome.org/GnomeGoals/CorrectDesktopFiles.

The patch attached is a proposition of correction.
Comment 1 Sebastian Pipping 2011-08-05 09:58:45 UTC 
The patch pachtes the name to "Sound-Juicer".  It should be "Sound Juicer" (space, not dash) to match what the app calls itself in its main window.
Comment 2 Alexandre Rostovtsev 2011-08-06 07:28:15 UTC 
Created attachment 193342 [details] [review]
updated desktop file patch

(In reply to comment #1)
> The patch pachtes the name to "Sound-Juicer".  It should be "Sound Juicer"
> (space, not dash) to match what the app calls itself in its main window.

... and here is a patch that does that.
Comment 3 Sebastian Pipping 2011-08-06 11:53:21 UTC 
(In reply to comment #2)
> ... and here is a patch that does that.

Looks just right.
Comment 4 Ross Burton 2011-08-06 13:33:17 UTC 
Review of attachment 193342 [details] [review]:

Looks good please commit.
Comment 5 Bastien Nocera 2011-08-30 09:47:59 UTC 
Please create git-formatted patches, so as to keep authorship.
Comment 6 Piotr Drąg 2011-09-10 15:08:04 UTC 
It looks like the wrong patch with a dash was pushed.
Comment 7 Bastien Nocera 2011-09-10 15:24:46 UTC 
(In reply to comment #6)
> It looks like the wrong patch with a dash was pushed.

Fixed, thanks.